Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set api gateway under an internal VPC fraemwork #5057

Closed
ekeren opened this issue Nov 26, 2023 · 10 comments
Closed

Set api gateway under an internal VPC fraemwork #5057

ekeren opened this issue Nov 26, 2023 · 10 comments
Labels
✨ enhancement New feature or request needs-discussion Further discussion is needed prior to impl 👠 platforms Issues relating to Wing Platform Providers

Comments

@ekeren
Copy link

ekeren commented Nov 26, 2023

Feature Spec

You can now setup cloud.Api inside newly created / exiting VPC.
The cloud.Api endpoint will be private and only accessible from within the vpc

Use Cases

NA

Implementation Notes

It might be enough to just create an example that is leverging existing policy/platform capabilities as as a reference implementation

https://winglang.slack.com/archives/C047QFSUL5R/p1700460092970559

Component

SDK, Plugins

Community Notes

  • Please vote by adding a 👍 reaction to the issue to help us prioritize.
  • If you are interested to work on this issue, please leave a comment.
  • If this issue is labeled needs-discussion, it means the spec has not been finalized yet. Please reach out on the #dev channel in the Wing Slack.
@ekeren ekeren added ✨ enhancement New feature or request needs-discussion Further discussion is needed prior to impl labels Nov 26, 2023
@ekeren
Copy link
Author

ekeren commented Nov 26, 2023

@rkazakov is there any specific information or use case you want to add to this issue?

@ekeren
Copy link
Author

ekeren commented Nov 26, 2023

@rkazakov
Copy link

Hey @ekeren,
Looks like it.
Endpoint Configuration allows to set endpoint type to PRIVATE and Private Integrations option has VPC_LINK.
Screenshot 2023-11-27 at 12 22 52 pm

@rkazakov
Copy link

I can't see how we can add a resource policy though.
resource-policy

@ekeren
Copy link
Author

ekeren commented Nov 28, 2023

This is a reference blog for how to setup your api gateway inside VPC

https://dulajra.medium.com/how-to-create-a-vpc-endpoint-for-api-gateway-a84bc7eeba28

@staycoolcall911 staycoolcall911 added the 👠 platforms Issues relating to Wing Platform Providers label Dec 12, 2023
@ekeren
Copy link
Author

ekeren commented Dec 21, 2023

related PR #5290

@ekeren
Copy link
Author

ekeren commented Dec 21, 2023

PR #5290 is merged, waiting for the release.

Once it is released, We need to make sure that this solution works by following instructions in https://github.com/ekeren/wing-apigatway-vpc

https://github.com/ekeren/wing-apigatway-vpc includes a custom provider that does the work placing all lambdas and Api Gateways inside the VPC

@ekeren
Copy link
Author

ekeren commented Dec 21, 2023

@rkazakov - Verified to work on my side

Can you please check instructions on https://github.com/ekeren/wing-apigatway-vpc and let me know if this works as you expected?

@staycoolcall911
Copy link
Contributor

@hasanaburayyan , @revitalbarletz - can we close this issue?

@rkazakov
Copy link

Hey @ekeren,
Apologies for the delay. Going to look into it in the next few days.
Cheers,
Ruslan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement New feature or request needs-discussion Further discussion is needed prior to impl 👠 platforms Issues relating to Wing Platform Providers
Projects
Archived in project
Development

No branches or pull requests

3 participants