cant lift objects from a custom platform

[eladcon]

I tried this:

write a custom platform for the awscdk target

// my-custom-platform/index.js
// this folder also has a package.json with @winglang/platform-awscdk as a dependency
const { Function } = require("@winglang/platform-awscdk/lib/function.js");
const {FUNCTION_FQN} = require("@winglang/sdk/lib/cloud");
module.exports.Platform = class Platform {
  newInstance(type,scope,id,props) {
    if (type === FUNCTION_FQN) {
      return new Function(scope, id, props);
    }
  }
}

compile a wing app with both platforms
CDK_STACK_NAME=test wing compile -t @winglang/platform-awscdk -t ../my-custom-platform/index.js main.w

// main.w
// this folder also has a package.json with @winglang/platform-awscdk as a dependency
bring cloud;

let b = new cloud.Bucket();

new cloud.Function(inflight () => {
  b.get("a");
});

This happened:

Error: buckets can only be bound by tfaws.Function for now

(the tfaws.Function is just a typo)

I expected this:

No response

Is there a workaround?

No response

Anything else?

No response

Wing Version

No response

Node.js Version

No response

Platform(s)

No response

Community Notes

• Please vote by adding a 👍 reaction to the issue to help us prioritize.
• If you are interested to work on this issue, please leave a comment.

[github-actions]

Hi,

This issue hasn't seen activity in 90 days. Therefore, we are marking this issue as stale for now. It will be closed after 7 days.
Feel free to re-open this issue when there's an update or relevant information to be added.
Thanks!

[github-actions]

Hi,

This issue hasn't seen activity in 90 days. Therefore, we are marking this issue as stale for now. It will be closed after 7 days.
Feel free to re-open this issue when there's an update or relevant information to be added.
Thanks!

[Chriscbr]

This error shouldn't be raised anymore since we've now defined a more general purpose "isAwsInflightHost" function -- see the check here:

wing/packages/@winglang/sdk/src/target-tf-aws/function.ts

Lines 309 to 311 in 9adaea0

	if (!AwsInflightHost.isAwsInflightHost(host)) {
	throw new Error("Host is expected to implement `IAwsInfightHost`");
	}

and the implementation here:

wing/packages/@winglang/sdk/src/shared-aws/inflight-host.ts

Line 11 in 9adaea0

public static isAwsInflightHost(obj: any): obj is IAwsInflightHost {

I've opened a separate issue for making sure we add this API for all of the major cloud targets: #7081