feat(sdk): simulator state #5164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! 🎉
|
|
Console preview environment is available at https://wing-console-pr-5164.fly.dev 🚀 Last Updated (UTC) 2023-12-14 16:12 |
BenchmarksComparison to Baseline ⬜⬜⬜⬜⬜🟩⬜⬜⬜⬜⬜⬜⬜
⬜ Within 1.5 standard deviations Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI. Results
Last Updated (UTC) 2023-12-14 16:47 |
Signed-off-by: monada-bot[bot] <monabot@monada.co>
Signed-off-by: monada-bot[bot] <monabot@monada.co>
monadabot
added
the
⚠️ pr/review-mutation
Chriscbr
removed
the
⚠️ pr/review-mutation
eladb
requested changes
Dec 11, 2023
Chriscbr
commented
Dec 12, 2023
Chriscbr
commented
Dec 12, 2023
Chriscbr
removed
the
⚠️ pr/review-mutation
Signed-off-by: monada-bot[bot] <monabot@monada.co>
monadabot
added
the
⚠️ pr/review-mutation
Chriscbr
removed
the
⚠️ pr/review-mutation
eladb
approved these changes
Dec 14, 2023
Chriscbr
removed
the
🚧 pr/do-not-merge
Chriscbr
commented
Dec 14, 2023
eladb
approved these changes
Dec 14, 2023
polamoros
approved these changes
Dec 14, 2023
|
Thanks for contributing, @Chriscbr! This PR will now be added to the merge queue, or immediately merged if |
14 tasks
|
Congrats! 🚀 This was released in Wing 0.51.33. |
5 tasks
mergify bot
pushed a commit
that referenced
this pull request
Dec 16, 2023
Fixes #5228 We discovered an issue where invalid errors were thrown in unit tests where a message is pushed to a queue and the queue had a consumer function. The problem occurred because a queue's simulation periodically processes messages, but this continued even after the queue consumer function is deleted during the simulator's cleanup. (I've shared some verbose test logs from the minimal repro in #5228 here: https://gist.github.com/Chriscbr/23fb248fb65d9e349da6e3347c90c866). To fix this, I updated the EventMapping resource so it also removes the its function from the queue's subscribers when the EventMapping is cleaned up. By doing this, we guarantee the function is removed from the queue's subscribers before the function is cleaned up, so when the queue tries processing messages, it will send the messages to another consumer or simply retain them in memory. Misc: - I also cleaned up some dead code that was previously used by the CLI for picking out distinct tests to run (no longer needed after #5164) ## Checklist - [x] Title matches [Winglang's style guide](https://www.winglang.io/contributing/start-here/pull_requests#how-are-pull-request-titles-formatted) - [x] Description explains motivation and solution - [x] Tests added (always) - [ ] Docs updated (only required for features) - [ ] Added `pr/e2e-full` label if this feature requires end-to-end testing *By submitting this pull request, I confirm that my contribution is made under the terms of the [Wing Cloud Contribution License](https://github.com/winglang/wing/blob/main/CONTRIBUTION_LICENSE.md)*.
This was referenced Dec 19, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the capability for the Wing simulator to store resource state across compilations. This means if you performed a lot of work to fill a
cloud.Bucketwith objects or values incloud.Counter, it will be remembered when you recompile and reload the application as long as the resource is still in your app. This will be extended to other resources like Queue and Workload in the future.Here's a screen recording - notice how even as the app is updated with new resources or different inflight code, the state of resources doesn't go away.
simulator-state-720.mov
Notes:
wing test).Future work:
Checklist
pr/e2e-fulllabel if this feature requires end-to-end testingBy submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.