Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose cloud endpoints through the console #5792

Merged
merged 17 commits into from
Mar 13, 2024
Merged

Conversation

eladcon
Copy link
Collaborator

@eladcon eladcon commented Feb 28, 2024

Depends on winglang/wing.cloud#574

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@monadabot
Copy link
Contributor

monadabot commented Feb 28, 2024

Console preview environment is available at https://wing-console-pr-5792.fly.dev 🚀

Last Updated (UTC) 2024-03-13 10:43

@monadabot
Copy link
Contributor

monadabot commented Feb 28, 2024

Benchmarks

Comparison to Baseline ⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜
Benchmark Before After Change
version 58ms±0.8 59ms±0.55 +0ms (+0.6%)⬜
functions_1.test.w -t sim 578ms±70.38 520ms±8.94 -58ms (-10.09%)⬜
functions_1.test.w -t tf-aws 946ms±9.04 948ms±4.47 +3ms (+0.3%)⬜
jsii_small.test.w -t sim 487ms±2.42 495ms±4.98 +8ms (+1.56%)⬜
jsii_small.test.w -t tf-aws 708ms±7.13 717ms±20.24 +9ms (+1.28%)⬜
jsii_big.test.w -t sim 2898ms±12.57 2907ms±11.63 +9ms (+0.3%)⬜
jsii_big.test.w -t tf-aws 3112ms±13.28 3107ms±11.67 -4ms (-0.14%)⬜
hello_world.test.w -t sim 517ms±2.81 520ms±3.22 +3ms (+0.59%)⬜
hello_world.test.w -t tf-aws 1642ms±3.3 1656ms±17.59 +14ms (+0.83%)⬜
empty.test.w -t sim 484ms±5.71 483ms±3.25 0ms (-0.06%)⬜
empty.test.w -t tf-aws 703ms±4.73 707ms±6.62 +4ms (+0.64%)⬜
functions_10.test.w -t sim 592ms±7.27 591ms±6.94 -1ms (-0.23%)⬜
functions_10.test.w -t tf-aws 2217ms±8.91 2230ms±6.64 +12ms (+0.56%)⬜

⬜ Within 1.5 standard deviations
🟩 Faster, Above 1.5 standard deviations
🟥 Slower, Above 1.5 standard deviations

Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI.

Results
name mean min max moe sd
version 59ms 58ms 60ms 1ms 1ms
functions_1.test.w -t sim 520ms 507ms 552ms 9ms 13ms
functions_1.test.w -t tf-aws 948ms 938ms 957ms 4ms 6ms
jsii_small.test.w -t sim 495ms 486ms 505ms 5ms 7ms
jsii_small.test.w -t tf-aws 717ms 699ms 796ms 20ms 28ms
jsii_big.test.w -t sim 2907ms 2884ms 2944ms 12ms 16ms
jsii_big.test.w -t tf-aws 3107ms 3084ms 3144ms 12ms 16ms
hello_world.test.w -t sim 520ms 512ms 527ms 3ms 5ms
hello_world.test.w -t tf-aws 1656ms 1632ms 1721ms 18ms 25ms
empty.test.w -t sim 483ms 477ms 492ms 3ms 5ms
empty.test.w -t tf-aws 707ms 693ms 723ms 7ms 9ms
functions_10.test.w -t sim 591ms 576ms 603ms 7ms 10ms
functions_10.test.w -t tf-aws 2230ms 2213ms 2245ms 7ms 9ms
Last Updated (UTC) 2024-03-13 10:49

Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn this is going to be an amazing feature!

@skyrpex skyrpex marked this pull request as ready for review March 13, 2024 09:41
@skyrpex skyrpex requested review from ainvoner, polamoros, skyrpex and a team as code owners March 13, 2024 09:41
Copy link
Contributor

mergify bot commented Mar 13, 2024

Thanks for contributing, @eladcon! This PR will now be added to the merge queue, or immediately merged if expose-endpoints is up-to-date with main and the queue is empty.

mergify bot added a commit that referenced this pull request Mar 13, 2024
Co-authored-by: Pol Amorós <info@polamoros.com>
Copy link
Contributor

mergify bot commented Mar 13, 2024

Thanks for contributing, @eladcon! This PR will now be added to the merge queue, or immediately merged if expose-endpoints is up-to-date with main and the queue is empty.

1 similar comment
Copy link
Contributor

mergify bot commented Mar 13, 2024

Thanks for contributing, @eladcon! This PR will now be added to the merge queue, or immediately merged if expose-endpoints is up-to-date with main and the queue is empty.

mergify bot added a commit that referenced this pull request Mar 13, 2024
@mergify mergify bot merged commit 215d206 into main Mar 13, 2024
15 checks passed
@mergify mergify bot deleted the expose-endpoints branch March 13, 2024 11:01
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.61.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants