Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some control changes aren't propagated back to the scope #45

Closed
rigdern opened this issue Jul 2, 2015 · 2 comments
Closed

Some control changes aren't propagated back to the scope #45

rigdern opened this issue Jul 2, 2015 · 2 comments

Comments

@rigdern
Copy link

rigdern commented Jul 2, 2015

When the user interacts with a control causing a control's property to change (e.g. the user closing a SplitView causes the paneOpened property to be false), this property change should be propagated into the angular scope.

We do this for most properties but we missed some:

  • Pivot: selectionchanged event affects selectedIndex and selectedItem
  • SemanticZoom: zoomchanged event affects zoomedOut
@jdalton jdalton added this to the 1507 milestone Jul 7, 2015
@AmazingJaze
Copy link
Contributor

@rigdern is this the same as #4 ?

@rigdern
Copy link
Author

rigdern commented Jul 9, 2015

It looks like they're related. #4 seems more comprehensive. #4 asks to do scrollPosition which requires batching because it's noisy and we don't do anything like that now.

This bug should be much easier because it only uses techniques we've already used in other places.

Ask @TheWrathOfConst what properties he had in mind for #4. I thought we already handled most of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants