-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typings on LoggerOptions and Logger interfaces. #2021
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'rejectionHandlers' field was missing on LoggerOptions interface at index.d.ts. Issue: winstonjs#1801
A complement to rejectionHandlers commit.
2 tasks
fearphage
approved these changes
Jan 11, 2022
Added RejectionHandler to Logger interface, Basically the same of PR: winstonjs#1929 Suggest by: winstonjs#2021 (comment)
fearphage
approved these changes
Jan 13, 2022
This was referenced Jan 13, 2022
This was referenced Jan 27, 2022
With Winston v3.7.1 installed, the rejections instance does not exist resulting in an unhandled exception.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some typings are missing on index.d.ts.
Missing fields:
on LoggerOptions interface:
on Logger interface (suggested by DABH):
Missing interfaces (suggested by DABH):
This commit fix it (3 commits):
Issue: #1801
One workaround for part of the problem(only for missing fields on LoggerOptions) is doing a declaration merging on winston module.