Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added 'rejections' to the default property exposer #1957

Closed
wants to merge 1 commit into from

Conversation

DiniFarb
Copy link

@DiniFarb DiniFarb commented Oct 1, 2021

Referencing to Issue #1955

@DiniFarb DiniFarb marked this pull request as ready for review October 1, 2021 06:00
@DiniFarb
Copy link
Author

DiniFarb commented Oct 1, 2021

Or maybe it is better to expose the rejections like the exception handler.

Something like this:

/**
 * Define getter for `rejections` which exposes the default `rejectionHandler`
 * @type {Object}
 */
Object.defineProperty(winston, 'rejections', {
  get() {
    return defaultLogger.rejections;
  }
});

@DiniFarb DiniFarb changed the title added 'rejections' to the default property exposer (#1955) added 'rejections' to the default property exposer Oct 1, 2021
@wbt
Copy link
Contributor

wbt commented Jan 27, 2022

Closing in favor of #2021 which has been merged in awaiting release. If you don't think that covers it, please comment for reopening!

@wbt wbt closed this Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants