Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

markdown/editors: Update preview when the file is saved #48

Merged
merged 1 commit into from
Jan 12, 2015

Conversation

oliviermartin
Copy link
Contributor

This change refresh the Markdown HTML Preview view when the editor is saved.

This change solves the issue #11 .

@paulvi
Copy link
Collaborator

paulvi commented Dec 30, 2014

will it save energy, when View is hidden ?

@paulvi paulvi mentioned this pull request Dec 30, 2014
@oliviermartin
Copy link
Contributor Author

It could be added as a future change.

I wanted to fix the major issue of updating the preview View. Without this change the user has to use a workaround to update the preview View such as switching to another source file and coming back on the .md file.

While with this change, the user only needs to save his/her .md file to update the preview.

@winterstein
Copy link
Owner

A few people have raised this issue, so glad to have it fixed.

@oliviermartin Have you tested it for if the preview view isn't present? Possibility for a NullPointerException here. Maybe wrap that update call in a try--catch block?

@oliviermartin
Copy link
Contributor Author

@winterstein good catch! I have just updated the patch to check if MarkdownPreview.preview is null.

@paulvi
Copy link
Collaborator

paulvi commented Dec 31, 2014

It could be added as a future change.

well, i'd like to do just one 1.2 release #52

@paulvi paulvi added this to the 1.2 milestone Dec 31, 2014
paulvi pushed a commit that referenced this pull request Jan 12, 2015
markdown/editors: Update preview when the file is saved
@paulvi paulvi merged commit 3a01679 into winterstein:master Jan 12, 2015
@paulvi paulvi mentioned this pull request Jan 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants