Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hash ('#') in code section interpreted as heading // new release? #71

Open
jludvice opened this issue Nov 14, 2016 · 11 comments
Open

hash ('#') in code section interpreted as heading // new release? #71

jludvice opened this issue Nov 14, 2016 · 11 comments

Comments

@jludvice
Copy link

Hello guys.
Would it be possible to fix this comment line being rendered as headline?
markdown-example


heading

# some comment
echo "asdf"
java -jar whatever.jar -Dasdf='abc'

@jludvice
Copy link
Author

Plugin version:
Markdown Editor 1.2.0.201501260515 markdown.editor.feature.feature.group Winterwell

@jludvice
Copy link
Author

@paulvi I just created duplicate of #67 and #68 didn't I? I'm sorry if I did.

@paulvi
Copy link
Collaborator

paulvi commented Nov 23, 2016

So was #68 not good fix? @JensPiegsa

@jludvice
Copy link
Author

I assume that commit fix 09e7630 is not present in editor version 1.2.0.201501260515, and I didn't try to compile from source.

@JensPiegsa
Copy link
Contributor

My commit only fixed the according issue in the outline view.
I also haven't looked into how a new version is deployed.
@winterstein : Any plans on a new release?

@paulvi
Copy link
Collaborator

paulvi commented Nov 28, 2016

I can do. But look also in #72

@winterstein
Copy link
Owner

winterstein commented Nov 28, 2016 via email

@paulvi
Copy link
Collaborator

paulvi commented Dec 3, 2016

I think @grosenberg is close to take over the project

From the History all latest changes were done by not me, but @tbrugz @oliviermartin

History

1.0
1.1 (24 Feb 2014) by Telmo Brugnara @tbrugz #40
Rich color preferences #35 #37
1.2 (Jan 2015) by Olivier Martin @oliviermartin #52
Update preview when the file is saved #48
MultiMarkdown metadata #49
GitHub code blocks #50
detecting links #51
open GFM View from Markdown View #53

@winterstein
Copy link
Owner

winterstein commented Dec 4, 2016 via email

@paulvi
Copy link
Collaborator

paulvi commented Dec 7, 2016

I am OK, fork at https://github.com/grosenberg/MarkdownEditor looks well

@paulvi paulvi changed the title hash ('#') in code section interpreted as heading hash ('#') in code section interpreted as heading // new release? Dec 7, 2016
@jludvice
Copy link
Author

jludvice commented Dec 9, 2016

I just tried to build plugin from sources and

  • outline view is correct
  • but editor still highlights code comment as heading :(

readme-headlines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants