Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed and Improved Multi-Markdown metadata support #49

Merged
merged 3 commits into from
Jan 26, 2015
Merged

Fixed and Improved Multi-Markdown metadata support #49

merged 3 commits into from
Jan 26, 2015

Conversation

oliviermartin
Copy link
Contributor

This patchset allows:

@paulvi
Copy link
Collaborator

paulvi commented Dec 30, 2014

@oliviermartin
Olivier, I can merge and release all, but let's wait for Daniel @winterstein to comment

@paulvi paulvi mentioned this pull request Dec 30, 2014
Closed
@winterstein
Copy link
Owner

Hello,
This looks fine to me. Thanks Olivier, and thank you Paul for managing a
release.
Happy New Year,

  • Dan

On 30 December 2014 at 11:15, Paul Verest notifications@github.com wrote:

@oliviermartin https://github.com/oliviermartin
Olivier, I can merge and release all, but let's wait for Daniel
@winterstein https://github.com/winterstein to comment

—
Reply to this email directly or view it on GitHub
#49 (comment)
.

Dr Daniel Winterstein
Director

A: CodeBase Argyle House, Edinburgh, EH3 9DR
M: +44 (0)772 5172 612
http://sodash.com

@paulvi
Copy link
Collaborator

paulvi commented Dec 31, 2014

@winterstein Dan, merge when you like and have no questions.

then discuss in #52 if to release 1.2

@paulvi paulvi added this to the 1.2 milestone Dec 31, 2014
@paulvi
Copy link
Collaborator

paulvi commented Jan 12, 2015

@oliviermartin this one can't be automatically merged.

Could you please update it to be on top of already merged #48 #50 #51

@paulvi
Copy link
Collaborator

paulvi commented Jan 12, 2015

Then I am to be build and test locally

If OK, I am going to release this January #52

@paulvi paulvi mentioned this pull request Jan 12, 2015
Closed
@oliviermartin
markdown/pagemodel: Fixed regular expression to detect metadata
c411f8b 
We only want to catch metadata keywords.
Other lines were caught with the former regular expression such
as heading containing a colon.
@oliviermartin
markdown/preferences: Added support to disable MultiMarkdown metadata…
1bdd3f1 
… parsing
@oliviermartin
markdown/pagemodel: Only parse the Multimarkdown metadata if there ar…
7183192 
…e valid

Prior to this change, metadata were parsed even if the metadata block
was not valid.

Example of non valid metadata block:
---------
Author: Olivier
---------

The MultiMarkdown format requires an empty line to be added at the
end of the metadata block.
@oliviermartin
Copy link
Contributor Author

Sorry, I missed your comment about the patch conflict. This new version should fix it.

@paulvi
Copy link
Collaborator

paulvi commented Jan 26, 2015

great

paulvi pushed a commit that referenced this pull request Jan 26, 2015
Merge pull request #49 from oliviermartin/fixed-multimarkdown-metadata
1d9eac2 
Fixed and Improved Multi-Markdown metadata support
@paulvi paulvi merged commit 1d9eac2 into winterstein:master Jan 26, 2015
@paulvi
Copy link
Collaborator

paulvi commented Jan 26, 2015

please check/improve README 5c3a320

@winterstein winterstein mentioned this pull request Dec 4, 2016
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oliviermartin @paulvi @winterstein