Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

markdown/pagemodel: Add support to detect links #51

Merged
merged 1 commit into from
Dec 30, 2014

Conversation

oliviermartin
Copy link
Contributor

This change detects URL that are not captured by Markdown
syntax.
The code adds '<' and '>' to these links.

This change should fix #41.

This change detects URL that are not captured by Markdown
syntax.
The code adds '<' and '>' to these links.
@paulvi
Copy link
Collaborator

paulvi commented Dec 30, 2014

Note: great, however is this automatic change?

I can lead to problem that .md files will become as change in version control system,
while user had no intention to change

Should it be optional ?

@oliviermartin
Copy link
Contributor Author

That's a good question. But the '<' & '>' are only added into the intermediate representation given to the Markdown library. Like that the Markdown library interprets the link as a Markdown link.

So, they do not appear into the source document (ie: the source document is kept unchanged).

@winterstein
Copy link
Owner

the source document is kept unchanged

That's good. Thanks Olivier.
This sounds like a good improvement, so I'm going to go ahead and merge. NB: I haven't tested it out.

winterstein added a commit that referenced this pull request Dec 30, 2014
markdown/pagemodel: Add support to detect links
@winterstein winterstein merged commit fcb3b7f into winterstein:master Dec 30, 2014
@paulvi
Copy link
Collaborator

paulvi commented Dec 31, 2014

NB: I haven't tested it out.

me too, so asking.

So if it for preview it will not fix #41 "Link highlight is misleading"

I thought, could there be option to insert '<' & '>' on save...

@paulvi paulvi added this to the 1.2 milestone Dec 31, 2014
@paulvi
Copy link
Collaborator

paulvi commented Dec 31, 2014

ref #52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link highlight is misleading
3 participants