Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making the status text more useful #149

Closed
gr2m opened this issue Nov 23, 2018 · 6 comments · Fixed by #161
Closed

Making the status text more useful #149

gr2m opened this issue Nov 23, 2018 · 6 comments · Fixed by #161
Labels

Comments

@gr2m
Copy link
Collaborator

gr2m commented Nov 23, 2018

Instead of just showing in progress – Work in progress I’d like to show something like in progress – "WIP" found in title

@HaydenMeloche
Copy link
Contributor

Hey @gr2m, I was wondering what exactly you are looking for in this feature? Might take a crack at it if I have time.

@gr2m
Copy link
Collaborator Author

gr2m commented Dec 3, 2018

Nice, thanks for offering help!

Right now, when WIP sets a status to pending, it’s shown like this in the list of statuses:

image

In progress — Work in progress

Which is quite repetitive.

The "Work in progress" part is actually the title of the check:

image

So instead I’d set the title to something more useful, like title contains "WIP". The check title is in two places:

title: 'Work in progress',

title: 'Work in progress',

If I recall correctly, there might be a problem with emoji when setting a status description directly, I’m not sure if checks have the same problem, we’d need to test.

Do you know how to run the app locally for testing?

@HaydenMeloche
Copy link
Contributor

HaydenMeloche commented Dec 3, 2018

@gr2m Thanks for the detailed response!

image

So if I'm not mistaken this is what you're looking for correct? 😄

I tried setting an emoji and it appears you were right about it not working correctly.
image

Any recommendations here?

@gr2m
Copy link
Collaborator Author

gr2m commented Dec 3, 2018

Thanks for looking into it!

So if I'm not mistaken this is what you're looking for correct? 😄

Yes!

I tried setting an emoji and it appears you were right about it not working correctly.

Maybe try to use the markdown code instead and see if it works? E.g. in this case it’s :construction:: https://api.github.com/emojis

If that works, we can look into a way to replace emoji into their markdown counterpart.

@HaydenMeloche
Copy link
Contributor

No luck 😞
image

@gr2m
Copy link
Collaborator Author

gr2m commented Dec 16, 2018

🎉 This issue has been resolved in version 3.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@gr2m gr2m added the released label Dec 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants