Making the status text more useful #149 #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gr2m
reviewed
Dec 4, 2018
HaydenMeloche
changed the title
HaydenMeloche
changed the title
|
How's this @gr2m ? |
Co-Authored-By: HaydenMeloche <meloche.hayden@gmail.com>
Co-Authored-By: HaydenMeloche <meloche.hayden@gmail.com>
|
With some further investigation it appears emojiRegex doesn't support everything. output = newStatus.match.replace(emojiRegex(), (match) => gemoji.unicode[match])
console.log(`Output ${output.name} - Match: ${newStatus.match}`);Output: |
|
I updated the package to gemoji now. I left it saving as a new variable that way the description in the details page still shows the original emoji. @gr2m thoughts? 😄 |
gr2m
approved these changes
Dec 16, 2018
|
🎉 This PR is included in version 3.9.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR #149 updates the title of the bot's check to be a little less repetitive. Unit tests were also updated to reflect this change.
Since emojis don't seem to work in the title (even with
:construction:) this is how they look:And everything else will look like:
Feedback is appreciated!
closes #149