Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide capability to configure when to block #91

Closed
tomkerkhove opened this issue Jun 10, 2018 · 5 comments
Closed

Provide capability to configure when to block #91

tomkerkhove opened this issue Jun 10, 2018 · 5 comments

Comments

@tomkerkhove
Copy link

Documentation says that the app checks the following

  1. The pull request title
  2. One of the pull request labels
  3. One of the pull request commit messages

Is there a way to configure it should block 1), but not for 2) & 3)?

@gr2m
Copy link
Collaborator

gr2m commented Jun 10, 2018

I’m working on it! I’m currently submitting WIP to the GitHub Marketplace, there will be the free version which will only check for the title and a $1/month version which will be configurable. This is all meant to be a reference implementation to other developers, all revenue will be donated to Rails Girls Summer of Code and I’ll keep it all public. And if folks can’t afford or don’t have a way to pay the $1/month I'm sure we can figure something out.

Best place to follow the updates on that is #89

What kind of configuration would you like to see to make it work with your workflows?

@tomkerkhove
Copy link
Author

Given your plans I'm ok with just the free option which checks the title (which is what I'm using).

The kind of configuration I was looking for was to enable/disable one of the rules described above.

@gr2m
Copy link
Collaborator

gr2m commented Jun 11, 2018

Great, thanks!

@gr2m gr2m closed this as completed Jun 11, 2018
@tomkerkhove
Copy link
Author

Looks like you've submitted it to the marketplace (#89) - Should I reconfigure it and be good to go?

@gr2m
Copy link
Collaborator

gr2m commented Jun 25, 2018

I think the submission to the marketplace shouldn’t affect you at all :) There might be a notification at some point where you will be asked to grant WIP a few more permissions, but other than that it should be all seamless for you. It'll still be the same app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants