Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why does WIP block PR without WIP title? #120

Closed
Kebap opened this issue Sep 10, 2018 · 4 comments
Closed

Why does WIP block PR without WIP title? #120

Kebap opened this issue Sep 10, 2018 · 4 comments

Comments

@Kebap
Copy link

Kebap commented Sep 10, 2018 •
edited
Loading

So I am interested in your bot and have just added it to a repository, however two pull requests seem to get blocked now, even though they do not have "WIP" or alike in title. Did I do something wrong?

Example 1: Mudlet/Mudlet#1836
Example 2: Mudlet/Mudlet#1716
@Kebap Kebap changed the title Why does WIP block PR without WIP text? Why does WIP block PR without WIP title? Sep 10, 2018
@Kebap
Copy link
Author

Kebap commented Sep 10, 2018

Seems like the commits interfere:

Example 1: The most recent commit has a title like "WIP" - ok, fair enough
Example 2: A much older commit has a title containing "WIP" - how to remedy?

@tomkerkhove
Copy link

I think you'll need to squash those commits into a new one.

There is something coming for this so that you can control it, see #91

@travi
Copy link

travi commented Sep 10, 2018

looks like the more current issue to follow is #96

@gr2m
Copy link
Collaborator

gr2m commented Sep 11, 2018

This will be resolved by #94. Can you watch that PR?

@gr2m gr2m closed this as completed Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gr2m @Kebap @travi @tomkerkhove