Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: typing indicator receiver logs and flag check (WPB-4706) #2110

Merged
merged 4 commits into from
Oct 2, 2023

Conversation

yamilmedina
Copy link
Contributor


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

We need to perform checks in order to clean the typing indicator.

  • Skip self user events
  • Take in consideration the user configuration about typing indicator to add to the cache

Solutions

  • Also added logs for the event handling.
  • Added more tests.

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

Unit Test Results

   439 files  ±0     439 suites  ±0   2m 51s ⏱️ +21s
2 387 tests +2  2 283 ✔️ +2  104 💤 ±0  0 ±0 

Results for commit 922fbb8. ± Comparison against base commit a7760c3.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Oct 2, 2023

Datadog Report

All test runs 1bc2391 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 1643 32 12.1s Link
kalium-jvm 0 0 0 2283 104 13m 36s Link

@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2023

Codecov Report

Merging #2110 (922fbb8) into develop (a7760c3) will increase coverage by 0.01%.
The diff coverage is 60.00%.

@@              Coverage Diff              @@
##             develop    #2110      +/-   ##
=============================================
+ Coverage      57.89%   57.90%   +0.01%     
  Complexity        24       24              
=============================================
  Files           1015     1015              
  Lines          38286    38296      +10     
  Branches        3490     3492       +2     
=============================================
+ Hits           22164    22176      +12     
+ Misses         14631    14627       -4     
- Partials        1491     1493       +2     
Files Coverage Δ
...gic/data/conversation/TypingIndicatorRepository.kt 76.92% <85.71%> (-2.25%) ⬇️
...um/logic/feature/conversation/ConversationScope.kt 0.00% <0.00%> (ø)
...ic/sync/receiver/handler/TypingIndicatorHandler.kt 82.35% <50.00%> (-7.65%) ⬇️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7760c3...922fbb8. Read the comment docs.

Copy link
Contributor

@gongracr gongracr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes 🙏 🍇 and smooth job as usual 🧤 🧤

@yamilmedina yamilmedina added this pull request to the merge queue Oct 2, 2023
Merged via the queue into develop with commit 5bb647a Oct 2, 2023
17 checks passed
@yamilmedina yamilmedina deleted the feat/typing-indicator-sender branch October 2, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants