feat: typing indicator in conversation view (WPB-4706) #2292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 1103 succeeded. The build produced the following APK's: |
Garzas
requested changes
Oct 2, 2023
| observeAudioPlayerState() | ||
| } | ||
|
|
||
| private fun observeUsersTypingState() { |
There was a problem hiding this comment.
I would prefer to have small view model for this state. This state is independent from others 🤔
ohassine
approved these changes
Oct 2, 2023
app/src/main/kotlin/com/wire/android/ui/home/conversations/UsersTypingIndicator.kt
Outdated
Show resolved
Hide resolved
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 1113 succeeded. The build produced the following APK's: |
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 1121 succeeded. The build produced the following APK's: |
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 1127 succeeded. The build produced the following APK's: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
We need to add the capability to add the typing indicator for conversations.
Causes (Optional)
Whenever another user is typing, we are going to show the writing pen indication.
Depends on
Testing
Test Coverage (Optional)
Attachments (Optional)
Screen.Recording.2023-10-02.at.11.37.16.mov
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.