feat(typing): send typing indicator events - epic (WP-4590) #2127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-4590) (#2118) * fix: exclude selfuser from typingevents * fix: exclude selfuser from typingevents * fix: coverage for flag check * chore: api configuration for sending typing status * chore: api configuration for sending typing status v0 * chore: api configuration for sending typing status v0 * chore: pr comments * feat: mapper and repo ops * feat: mapper and repo ops * feat: mapper and repo ops * chore: detekt * chore: detekt * chore: tests broken * feat(typing): send typing indicator events use case and cleanup code pt2. (WPB-4590) (#2121) * feat: mapper and repo ops deletion * chore: ip * chore: some fun refactoring, just ideas * chore: some fun refactoring, just ideas * chore: some fun refactoring, just ideas * chore: working base * chore: clear indicators * chore: clear indicators * chore: clear indicators * chore: notes * chore: refactor into new classes splitted * chore: comments cleanup * chore: detekt fixes * Empty-Commit * feat(typing): send typing indicator event tests pt3. (WPB-4590) (#2122) * chore: test cov * chore: test cov * chore: test cov * chore: test cov * chore: test cov
yamilmedina
requested review from
Garzas,
alexandreferris,
vitorhugods and
ohassine
github-actions
bot
added
🚨 Potential breaking changes
👕 size: XL
type: feature ✨
labels
alexandreferris
approved these changes
Oct 10, 2023
yamilmedina
changed the title
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed Test Services
|
gongracr
approved these changes
Oct 11, 2023
| userTypingCache.block { entry -> | ||
| entry.clear() | ||
| }.also { | ||
| userTypingDataSourceFlow.tryEmit(Unit) |
There was a problem hiding this comment.
Not sure why we are using tryEmit if we are not checking the result value?
There was a problem hiding this comment.
This is so we can make the Observers of userTypingDataSourceFlow collect the new state. Since we are relying on this flow to get new map userTypingCache states to consumers.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Collection of small PRs that brings alive the sending typing indicator, plus some refactor on the receiving part to make it more stable, testable and mantainable.
The PRs already reviewd.
Testing
Test Coverage (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.