feat: epic typing indicator sender (WPB-4590) #2315

yamilmedina · 2023-10-11T12:06:45Z

WPB-4590 Sending conversation.typing events

PR Submission Checklist for internal contributors

The PR Title
- conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
- contains a reference JIRA issue number like SQPIT-764
- answers the question: If merged, this PR will: ... ³
The PR Description
- is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Send typing indicators events to conversation.

Needs releases with:

feat(typing): send typing indicator events - epic (WP-4590) kalium#2127
GitHub link to other pull request

Testing

Test Coverage (Optional)

I have added automated test to this contribution

Attachments (Optional)

Screen.Recording.2023-10-11.at.14.04.42.mov

PR Post Submission Checklist for internal contributors (Optional)

Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References

https://sparkbox.com/foundry/semantic_commit_messages
https://github.com/wireapp/.github#usage
E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

codecov · 2023-10-11T12:57:46Z

Codecov Report

Merging #2315 (5e741d2) into develop (016560c) will increase coverage by 0.23%.
The diff coverage is 63.15%.

@@              Coverage Diff              @@
##             develop    #2315      +/-   ##
=============================================
+ Coverage      41.04%   41.28%   +0.23%     
- Complexity      1048     1050       +2     
=============================================
  Files            328      328              
  Lines          11902    11918      +16     
  Branches        1586     1588       +2     
=============================================
+ Hits            4885     4920      +35     
+ Misses          6547     6530      -17     
+ Partials         470      468       -2

Files	Coverage Δ
.../ui/home/conversations/MessageComposerViewModel.kt	`80.81% <100.00%> (+6.75%)`	⬆️
...rsations/messages/ConversationMessagesViewModel.kt	`62.04% <100.00%> (+0.93%)`	⬆️
.../messagecomposer/state/MessageCompositionHolder.kt	`32.42% <0.00%> (+3.78%)`	⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 016560c...5e741d2. Read the comment docs.

github-actions · 2023-10-11T13:09:09Z

Test Results

644 tests +3 644 ✔️ +3 7m 42s ⏱️ - 1m 38s
  93 suites ±0     0 💤 ±0
  93 files ±0     0 ❌ ±0

Results for commit 5e741d2. ± Comparison against base commit 016560c.

♻️ This comment has been updated with latest results.

github-actions · 2023-10-11T13:09:11Z

APKs built during tests are available here. Scroll down to Artifacts!

AndroidBob · 2023-10-11T13:23:24Z

Build 1241 failed.

github-actions · 2023-10-11T13:57:52Z

APKs built during tests are available here. Scroll down to Artifacts!

AndroidBob · 2023-10-11T14:07:03Z

Build 1242 succeeded.

The build produced the following APK's:

com.wire.android-v4.5.0(7806415)(7806415)-staging-compat.apk

gongracr

Real nice ✨ and extra bonus points for the nice tests 🧪 💪

gongracr · 2023-10-11T14:52:46Z

app/src/main/kotlin/com/wire/android/ui/home/conversations/UsersTypingIndicator.kt

+            initialValue = -10f, targetValue = -2f,
            animationSpec = infiniteRepeatable(
-                animation = tween(1_000, easing = FastOutSlowInEasing),
+                animation = tween(1_500, easing = FastOutSlowInEasing),


Do we want to extract these values to some Dimens variable for easier concurrent modification?

Good idea, I'll take a look on how we are doing for some animations,
I tried to look for dimensions that fit, but didn't find anything so far

gongracr · 2023-10-11T14:52:57Z

app/src/main/kotlin/com/wire/android/ui/home/conversations/UsersTypingIndicator.kt

+            initialValue = 0.1f,
+            targetValue = 1f,
+            animationSpec = infiniteRepeatable(
+                animation = tween(durationMillis = 1_500, easing = FastOutLinearInEasing),


same than above

github-actions · 2023-10-11T22:57:01Z

APKs built during tests are available here. Scroll down to Artifacts!

AndroidBob · 2023-10-11T23:13:44Z

Build 1249 succeeded.

The build produced the following APK's:

com.wire.android-v4.5.0(7809684)(7809684)-staging-compat.apk

yamilmedina added 12 commits October 6, 2023 18:45

chore: clear indicators and send wip

c9fe84d

chore: clear indicators and send wip

4d1e7ee

chore: fix displaying issues and setup for sending events

c36d07d

chore: wip

b60fe90

Merge branch 'develop' into feat/epic-typing-indicator-sender

3275d17

chore: kalium ref

a8fbb3a

fix: wire send stop on sending message

687eff9

fix: wire send stop on sending message

02dc76b

fix: wire send stop on sending message

66b70d9

fix: animation improv

abc2d70

feat: add missing usecase and move di to proper module

3cc9eab

fix: detekt

567334b

pull-request-size bot added the size/L label Oct 11, 2023

github-actions bot assigned yamilmedina Oct 11, 2023

yamilmedina added 5 commits October 11, 2023 14:26

fix: tests

eb282f6

fix: tests

8e60132

fix: tests

42b7bce

fix: tests

33acf3f

Merge branch 'develop' into feat/epic-typing-indicator-sender

e0279f3

feat: clear orphaned events on navigation

503cccf

feat: clear orphaned events on navigation

133b25e

yamilmedina requested review from a team and typfel and removed request for a team October 11, 2023 14:34

yamilmedina requested review from alexandreferris, borichellow, vitorhugods, saleniuk and Garzas October 11, 2023 14:34

gongracr approved these changes Oct 11, 2023

View reviewed changes

vitorhugods approved these changes Oct 11, 2023

View reviewed changes

alexandreferris approved these changes Oct 11, 2023

View reviewed changes

yamilmedina added 2 commits October 12, 2023 00:22

feat: adjustments

375ca3a

feat: adjustments pr

5e741d2

yamilmedina enabled auto-merge October 11, 2023 22:29

yamilmedina added this pull request to the merge queue Oct 11, 2023

Merged via the queue into develop with commit e096a5b Oct 11, 2023
14 of 15 checks passed

yamilmedina deleted the feat/epic-typing-indicator-sender branch October 11, 2023 23:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: epic typing indicator sender (WPB-4590) #2315

feat: epic typing indicator sender (WPB-4590) #2315

yamilmedina commented Oct 11, 2023 •

edited by github-actions bot

codecov bot commented Oct 11, 2023 •

edited

github-actions bot commented Oct 11, 2023 •

edited

github-actions bot commented Oct 11, 2023

AndroidBob commented Oct 11, 2023

github-actions bot commented Oct 11, 2023

AndroidBob commented Oct 11, 2023

gongracr left a comment

gongracr Oct 11, 2023

yamilmedina Oct 11, 2023

gongracr Oct 11, 2023

github-actions bot commented Oct 11, 2023

AndroidBob commented Oct 11, 2023

feat: epic typing indicator sender (WPB-4590) #2315

feat: epic typing indicator sender (WPB-4590) #2315

Conversation

yamilmedina commented Oct 11, 2023 • edited by github-actions bot

PR Submission Checklist for internal contributors

What's new in this PR?

Testing

Test Coverage (Optional)

Attachments (Optional)

PR Post Submission Checklist for internal contributors (Optional)

PR Post Merge Checklist for internal contributors

References

codecov bot commented Oct 11, 2023 • edited

Codecov Report

github-actions bot commented Oct 11, 2023 • edited

Test Results

github-actions bot commented Oct 11, 2023

AndroidBob commented Oct 11, 2023

github-actions bot commented Oct 11, 2023

AndroidBob commented Oct 11, 2023

gongracr left a comment

Choose a reason for hiding this comment

gongracr Oct 11, 2023

Choose a reason for hiding this comment

yamilmedina Oct 11, 2023

Choose a reason for hiding this comment

gongracr Oct 11, 2023

Choose a reason for hiding this comment

github-actions bot commented Oct 11, 2023

AndroidBob commented Oct 11, 2023

yamilmedina commented Oct 11, 2023 •

edited by github-actions bot

codecov bot commented Oct 11, 2023 •

edited

github-actions bot commented Oct 11, 2023 •

edited