Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: archive only locally [WPB-5006] #2162

Merged
merged 4 commits into from
Oct 25, 2023
Merged

feat: archive only locally [WPB-5006] #2162

merged 4 commits into from
Oct 25, 2023

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Oct 23, 2023 •
edited

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Added option to control if we should archive only locally conversation. It's needed when user is no longer a member of conversation and want to archive this conversation

@Garzas Garzas self-assigned this Oct 23, 2023
@Garzas Garzas requested review from typfel and ohassine and removed request for a team October 23, 2023 14:19
@Garzas Garzas changed the title feat: archive only locally feat: archive only locally [WPB-5006] Oct 23, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2023 •
edited

Unit Test Results

       1 files         1 suites   9s ⏱️
1 803 tests 1 798 ✔️ 5 💤 0 ❌

Results for commit bbd9de2.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Oct 23, 2023 •
edited

Datadog Report

All test runs 3e45add 🔗

✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 1776 30 9.09s Link
kalium-jvm 0 0 0 2459 104 11m 46s Link

@Garzas Garzas mentioned this pull request Oct 24, 2023
Merged
4 tasks
@Garzas Garzas enabled auto-merge October 25, 2023 09:01
@Garzas Garzas added this pull request to the merge queue Oct 25, 2023
Merged via the queue into develop with commit ca4d92a Oct 25, 2023
17 checks passed
@Garzas Garzas deleted the feat/archive-only-locally branch October 25, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yamilmedina yamilmedina yamilmedina approved these changes

@alexandreferris alexandreferris alexandreferris approved these changes

@saleniuk saleniuk Awaiting requested review from saleniuk

@typfel typfel Awaiting requested review from typfel typfel was automatically assigned from wireapp/android

@ohassine ohassine Awaiting requested review from ohassine ohassine was automatically assigned from wireapp/android

Assignees

@Garzas Garzas

Labels
🚨 Potential breaking changes 👕 size: M type: feature ✨
Projects
None yet
Milestone
No milestone
3 participants
@Garzas @yamilmedina @alexandreferris