Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: archive locally for non members [WPB-5006] #2366

Merged
merged 6 commits into from Oct 25, 2023

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Oct 24, 2023

BugWPB-5006 [Android] When user left or is removed a group conversation, he can not archive it anymore


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

When user is no longer a member of conversation he cannot archive it because API returns not found error

Solutions

Give user option to archive conversation locally when he is not a conversation member

Needs releases with:

wireapp/kalium#2162

@Garzas Garzas self-assigned this Oct 24, 2023
@Garzas Garzas requested review from typfel and borichellow and removed request for a team October 24, 2023 06:54
@AndroidBob
Copy link
Collaborator

Build 1491 failed.

@Garzas Garzas enabled auto-merge October 25, 2023 10:39
@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2023

Test Results

652 tests  ±0   652 ✔️ ±0   6m 16s ⏱️ - 2m 16s
  96 suites ±0       0 💤 ±0 
  96 files   ±0       0 ±0 

Results for commit 93bc881. ± Comparison against base commit 1385f09.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 1515 failed.

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #2366 (93bc881) into develop (1385f09) will increase coverage by 0.03%.
Report is 1 commits behind head on develop.
The diff coverage is 84.61%.

@@              Coverage Diff              @@
##             develop    #2366      +/-   ##
=============================================
+ Coverage      41.39%   41.42%   +0.03%     
  Complexity      1068     1068              
=============================================
  Files            340      340              
  Lines          12150    12160      +10     
  Branches        1598     1600       +2     
=============================================
+ Hits            5029     5037       +8     
  Misses          6644     6644              
- Partials         477      479       +2     
Files Coverage Δ
...i/home/conversationslist/model/GroupDialogState.kt 66.66% <100.00%> (+4.16%) ⬆️
...tions/details/GroupConversationDetailsViewModel.kt 60.09% <83.33%> (+0.50%) ⬆️
...ome/conversationslist/ConversationListViewModel.kt 58.03% <80.00%> (+0.30%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1385f09...93bc881. Read the comment docs.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1518 succeeded.

The build produced the following APK's:

@Garzas Garzas added this pull request to the merge queue Oct 25, 2023
Merged via the queue into develop with commit d939a9b Oct 25, 2023
15 checks passed
@Garzas Garzas deleted the feat/archive-locally-for-non-members branch October 25, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants