Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: asset view [WPB-4989] #2260

Merged
merged 16 commits into from
Dec 4, 2023
Merged

feat: asset view [WPB-4989] #2260

merged 16 commits into from
Dec 4, 2023

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Nov 24, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • asset view with pagination for fetching asset messages for media gallery

Copy link
Contributor

github-actions bot commented Nov 24, 2023

Unit Test Results

   395 files   -   84     395 suites   - 84   28s ⏱️ - 1m 58s
2 301 tests  - 371  2 235 ✔️  - 333  66 💤  - 38  0 ±0 

Results for commit 61f927d. ± Comparison against base commit e2f290b.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2023

Codecov Report

Merging #2260 (61f927d) into develop (e2f290b) will increase coverage by 0.00%.
The diff coverage is 69.14%.

Additional details and impacted files
@@             Coverage Diff             @@
##             develop    #2260    +/-   ##
===========================================
  Coverage      58.09%   58.10%            
  Complexity        21       21            
===========================================
  Files           1087     1092     +5     
  Lines          41054    41244   +190     
  Branches        3804     3812     +8     
===========================================
+ Hits           23851    23964   +113     
- Misses         15577    15647    +70     
- Partials        1626     1633     +7     
Files Coverage Δ
...n/com/wire/kalium/logic/data/asset/AssetMessage.kt 100.00% <100.00%> (ø)
...ire/kalium/logic/data/message/MessageRepository.kt 47.58% <100.00%> (+1.52%) ⬆️
...re/asset/GetAssetMessagesForConversationUseCase.kt 100.00% <100.00%> (ø)
...kalium/persistence/dao/asset/AssetMessageEntity.kt 100.00% <100.00%> (ø)
.../wire/kalium/persistence/dao/message/MessageDAO.kt 100.00% <ø> (ø)
.../wire/kalium/persistence/db/UserDatabaseBuilder.kt 79.33% <100.00%> (+0.17%) ⬆️
...n/kotlin/com/wire/kalium/logic/data/asset/Asset.kt 73.33% <85.71%> (+4.58%) ⬆️
...e/kalium/persistence/dao/message/MessageDAOImpl.kt 63.82% <91.66%> (+1.49%) ⬆️
...re/kalium/persistence/dao/message/MessageMapper.kt 57.42% <91.66%> (+1.26%) ⬆️
.../wire/kalium/logic/feature/message/MessageScope.kt 0.00% <0.00%> (ø)
... and 2 more

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2f290b...61f927d. Read the comment docs.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Nov 24, 2023

Datadog Report

All test runs c37a314 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 2409 94 5m 51.09s Link
kalium-jvm 0 0 0 2565 104 7m 18.04s Link

Copy link
Contributor

@alexandreferris alexandreferris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work!

just one nitpick and a quick question 🤔

Copy link
Contributor

github-actions bot commented Dec 1, 2023

Test Results

2 508 tests  +2 508   2 414 ✔️ +2 414   22s ⏱️ +22s
   444 suites +   444        94 💤 +     94 
   444 files   +   444          0 ±       0 

Results for commit 7c2dade. ± Comparison against base commit 2ddf5b8.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Dec 4, 2023

Datadog Report

All test runs 3ef7486 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 2414 94 6m 48.1s Link
kalium-jvm 0 0 0 2570 104 7m 26.04s Link

@Garzas Garzas added this pull request to the merge queue Dec 4, 2023
Merged via the queue into develop with commit c2e46cd Dec 4, 2023
17 checks passed
@Garzas Garzas deleted the feat/asset-view branch December 4, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants