-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: asset view [WPB-4989] #2260
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2260 +/- ##
===========================================
Coverage 58.09% 58.10%
Complexity 21 21
===========================================
Files 1087 1092 +5
Lines 41054 41244 +190
Branches 3804 3812 +8
===========================================
+ Hits 23851 23964 +113
- Misses 15577 15647 +70
- Partials 1626 1633 +7
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed Test Services
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work!
just one nitpick and a quick question 🤔
persistence/src/commonMain/kotlin/com/wire/kalium/persistence/dao/message/MessageDAOImpl.kt
Outdated
Show resolved
Hide resolved
persistence/src/commonMain/kotlin/com/wire/kalium/persistence/dao/message/MessageMapper.kt
Show resolved
Hide resolved
persistence/src/commonTest/kotlin/com/wire/kalium/persistence/dao/message/MessageDAOTest.kt
Outdated
Show resolved
Hide resolved
...mmonMain/kotlin/com/wire/kalium/logic/feature/asset/GetAssetMessagesByConversationUseCase.kt
Outdated
Show resolved
Hide resolved
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed Test Services
|
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?