feat: media gallery [WPB-4989] #2490

Garzas · 2023-12-01T10:12:09Z

WPB-4989 [Android] Gallery for media files in a conversation

PR Submission Checklist for internal contributors

The PR Title
- conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
- contains a reference JIRA issue number like SQPIT-764
- answers the question: If merged, this PR will: ... ³
The PR Description
- is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

implemented ConversationMediaGallery with image assets
added month/year labels to group asset images

Loading image assets functionality is slightly different then loading conversation messages, reasons:

paging-compose is not allowing to control when load more images, using it will cause out of memory error, because messages loading loads images asynchronously, we can't allow to load 20 images at once on screen, especially when they can have big size
moved control of loading next batches to ConversationAssetMessagesViewModel which checks if user scrolls LazyColumn to bottom by

val shouldContinue by remember {
        derivedStateOf {
            !scrollState.canScrollForward
        }
    }

waits for GetAssetMessagesForConversationUseCase to load asset's sequentially, currently BATCH_SIZE equals 5
added new type of MediaAssetImage : AsyncImageMessage which avoids using asynchronous image load from network to load only image from storage, because images are saved already in view model

Video with loading images when they are already downloaded
https://github.com/wireapp/wire-android/assets/13151239/ba087453-4134-4141-852a-d4ce1598ba65

Wideo With images which are not yet downloaded (for example when we restored backup)
https://github.com/wireapp/wire-android/assets/13151239/2b1209d7-fbc8-4e58-b5fa-4e37934f1292

Screen with failed image

Needs releases with:

wireapp/kalium#2260

Testing

Test Coverage (Optional)

I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)

PR Post Submission Checklist for internal contributors (Optional)

Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References

https://sparkbox.com/foundry/semantic_commit_messages
https://github.com/wireapp/.github#usage
E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

github-actions · 2023-12-01T10:25:36Z

Test Results

714 tests ±0 714 ✔️ ±0 9m 56s ⏱️ +47s
  99 suites ±0     0 💤 ±0
  99 files ±0     0 ❌ ±0

Results for commit b042df0. ± Comparison against base commit 7e67653.

♻️ This comment has been updated with latest results.

codecov · 2023-12-01T10:51:58Z

Codecov Report

Merging #2490 (b042df0) into develop (f3108ca) will decrease coverage by 0.27%.
Report is 1 commits behind head on develop.
The diff coverage is 1.19%.

Additional details and impacted files

@@              Coverage Diff              @@
##             develop    #2490      +/-   ##
=============================================
- Coverage      41.45%   41.19%   -0.27%     
  Complexity      1105     1105              
=============================================
  Files            348      353       +5     
  Lines          12767    12848      +81     
  Branches        1668     1676       +8     
=============================================
  Hits            5293     5293              
- Misses          6976     7057      +81     
  Partials         498      498

Files	Coverage Δ
.../kotlin/com/wire/android/GlobalObserversManager.kt	`80.00% <100.00%> (ø)`
...ome/conversationslist/ConversationListViewModel.kt	`59.68% <ø> (ø)`
...wire/android/mapper/RegularMessageContentMapper.kt	`23.94% <0.00%> (ø)`
...tlin/com/wire/android/migration/MigrationMapper.kt	`0.00% <0.00%> (ø)`
...me/conversations/media/ConversationMediaNavArgs.kt	`0.00% <0.00%> (ø)`
...ations/media/ConversationAssetMessagesViewState.kt	`0.00% <0.00%> (ø)`
...sations/model/messagetypes/asset/UIAssetMessage.kt	`0.00% <0.00%> (ø)`
...in/kotlin/com/wire/android/mapper/UIAssetMapper.kt	`0.00% <0.00%> (ø)`
...ations/media/ConversationAssetMessagesViewModel.kt	`0.00% <0.00%> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e67653...b042df0. Read the comment docs.

github-actions · 2023-12-01T10:58:22Z

APKs built during tests are available here. Scroll down to Artifacts!

alexandreferris

Looking great 👌🏻

Just have 2 small comments to use dimensions

alexandreferris · 2023-12-01T11:13:43Z

app/src/main/kotlin/com/wire/android/ui/home/conversations/media/ConversationMediaScreen.kt

+            .background(color = colorsScheme().backgroundVariant),
+        topBar = {
+            WireCenterAlignedTopAppBar(
+                elevation = 0.dp,


Suggested change

elevation = 0.dp,

elevation = dimensions().spacing0x,

alexandreferris · 2023-12-01T11:21:04Z

app/src/main/kotlin/com/wire/android/ui/home/conversations/model/MessageTypes.kt

+                color = MaterialTheme.wireColorScheme.onPrimary, shape = RoundedCornerShape(dimensions().messageAssetBorderRadius)
+            )
+            .border(
+                width = 1.dp,


Suggested change

width = 1.dp,

width = dimensions().spacing1x,

AndroidBob · 2023-12-01T11:28:27Z

Build 2099 succeeded.

The build produced the following APK's:

com.wire.android-v4.6.0(8246046)(8246046)-staging-compat.apk

app/src/main/kotlin/com/wire/android/mapper/UIAssetMapper.kt

...in/kotlin/com/wire/android/ui/home/conversations/media/ConversationAssetMessagesViewModel.kt

...in/kotlin/com/wire/android/ui/home/conversations/media/ConversationAssetMessagesViewState.kt

app/src/main/kotlin/com/wire/android/ui/home/conversations/media/ConversationMediaButton.kt

app/src/main/kotlin/com/wire/android/ui/home/conversations/media/ImageAssetsContent.kt

...in/kotlin/com/wire/android/ui/home/conversations/media/ConversationAssetMessagesViewModel.kt

AndroidBob · 2023-12-04T06:01:08Z

Build 2115 failed.

alexandreferris

👌🏻

github-actions · 2023-12-04T09:17:18Z

APKs built during tests are available here. Scroll down to Artifacts!

AndroidBob · 2023-12-04T09:39:36Z

Build 2120 succeeded.

The build produced the following APK's:

com.wire.android-v4.6.0(8271333)(8271333)-staging-compat.apk

github-actions · 2023-12-04T11:13:15Z

APKs built during tests are available here. Scroll down to Artifacts!

github-actions · 2023-12-04T11:40:57Z

APKs built during tests are available here. Scroll down to Artifacts!

AndroidBob · 2023-12-04T12:09:33Z

Build 2129 succeeded.

The build produced the following APK's:

com.wire.android-v4.6.0(8272185)(8272185)-staging-compat.apk

Garzas added 7 commits November 24, 2023 17:41

feat: media gallery

65d581a

Merge branch 'develop' into feat/media-gallery

287f666

Merge branch 'develop' into feat/media-gallery

d2ff2b9

code improvements

ccb9e50

feat: assets month labels

019a955

kalium update

74392dc

kalium update

8fa34b8

Garzas requested review from alexandreferris, MohamadJaara and saleniuk December 1, 2023 10:12

Garzas self-assigned this Dec 1, 2023

pull-request-size bot added the size/XL label Dec 1, 2023

Garzas added 2 commits December 1, 2023 21:13

kalium update

e845f78

Merge branch 'develop' into feat/media-gallery

8e74a9e

detekt fix

7816aeb

Garzas requested review from yamilmedina and vitorhugods December 1, 2023 10:35

alexandreferris reviewed Dec 1, 2023

View reviewed changes

saleniuk reviewed Dec 1, 2023

View reviewed changes

review fixes

e67c3c1

saleniuk approved these changes Dec 4, 2023

View reviewed changes

Garzas requested a review from alexandreferris December 4, 2023 08:47

review fixes

d89cdfd

alexandreferris approved these changes Dec 4, 2023

View reviewed changes

Garzas added 2 commits December 4, 2023 20:21

kalium update

048624e

Merge branch 'develop' into feat/media-gallery

775c426

Garzas added 2 commits December 4, 2023 21:44

Merge branch 'develop' into feat/media-gallery

f6e4924

kalium update

b042df0

Garzas enabled auto-merge December 4, 2023 11:17

Garzas added this pull request to the merge queue Dec 4, 2023

Merged via the queue into develop with commit fc6e59e Dec 4, 2023
14 of 15 checks passed

Garzas deleted the feat/media-gallery branch December 4, 2023 11:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: media gallery [WPB-4989] #2490

feat: media gallery [WPB-4989] #2490

Garzas commented Dec 1, 2023 •

edited by github-actions bot

github-actions bot commented Dec 1, 2023 •

edited

codecov bot commented Dec 1, 2023 •

edited

github-actions bot commented Dec 1, 2023

alexandreferris left a comment

alexandreferris Dec 1, 2023

alexandreferris Dec 1, 2023

AndroidBob commented Dec 1, 2023

AndroidBob commented Dec 4, 2023

alexandreferris left a comment

github-actions bot commented Dec 4, 2023

AndroidBob commented Dec 4, 2023

github-actions bot commented Dec 4, 2023

github-actions bot commented Dec 4, 2023

AndroidBob commented Dec 4, 2023

feat: media gallery [WPB-4989] #2490

feat: media gallery [WPB-4989] #2490

Conversation

Garzas commented Dec 1, 2023 • edited by github-actions bot

PR Submission Checklist for internal contributors

What's new in this PR?

Testing

Test Coverage (Optional)

How to Test

Notes (Optional)

Attachments (Optional)

PR Post Submission Checklist for internal contributors (Optional)

PR Post Merge Checklist for internal contributors

References

github-actions bot commented Dec 1, 2023 • edited

Test Results

codecov bot commented Dec 1, 2023 • edited

Codecov Report

github-actions bot commented Dec 1, 2023

alexandreferris left a comment

Choose a reason for hiding this comment

alexandreferris Dec 1, 2023

Choose a reason for hiding this comment

alexandreferris Dec 1, 2023

Choose a reason for hiding this comment

AndroidBob commented Dec 1, 2023

AndroidBob commented Dec 4, 2023

alexandreferris left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 4, 2023

AndroidBob commented Dec 4, 2023

github-actions bot commented Dec 4, 2023

github-actions bot commented Dec 4, 2023

AndroidBob commented Dec 4, 2023

Garzas commented Dec 1, 2023 •

edited by github-actions bot

github-actions bot commented Dec 1, 2023 •

edited

codecov bot commented Dec 1, 2023 •

edited