feat(mls): reevaluate protocol on demand [WPB-5049] #2278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced a new UseCase, NotifyConversationIsOpenUseCase, to notify when a conversation is open. This new use case allows the performing of update operations like protocol reevaluation in a lazy manner when a conversation is opened. This addition improves the app's responsiveness when user navigates to it, in case there was no protocol migration before.
vitorhugods
requested review from
a team,
typfel,
alexandreferris,
MohamadJaara,
mchenani and
Garzas
and removed request for
a team
Test Results1 888 tests - 778 1 858 ✔️ - 704 14s ⏱️ - 2m 4s Results for commit 96eded9. ± Comparison against base commit 2c6d056. This pull request removes 2666 and adds 1888 tests. Note that renamed tests count towards both.This pull request removes 104 skipped tests and adds 30 skipped tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2278 +/- ##
==========================================
Coverage 57.86% 57.87%
Complexity 21 21
==========================================
Files 1086 1087 +1
Lines 41068 41090 +22
Branches 3804 3805 +1
==========================================
+ Hits 23763 23779 +16
- Misses 15702 15707 +5
- Partials 1603 1604 +1
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
...monMain/kotlin/com/wire/kalium/logic/feature/conversation/NotifyConversationIsOpenUseCase.kt
Outdated
Show resolved
Hide resolved
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed Test Services
|
...monMain/kotlin/com/wire/kalium/logic/feature/conversation/NotifyConversationIsOpenUseCase.kt
Outdated
Show resolved
Hide resolved
alexandreferris
approved these changes
Nov 30, 2023
ohassine
approved these changes
Dec 1, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
We should have a fallback / safety net for 1:1 migrations.
Solutions
Expose a way to notify Kalium that a conversation is being displayed to the user.
This way, Kalium can do some sanity checks.
When calling
NotifyConversationIsOpenUseCase, Kalium can check if the conversation is 1:1 and if its protocol is up-to-date.Testing
Test Coverage
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.