Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mls): reevaluate protocol on demand [WPB-5049] #2502

Merged
merged 2 commits into from Dec 5, 2023

Conversation

vitorhugods
Copy link
Contributor

@vitorhugods vitorhugods commented Dec 4, 2023

TaskWPB-5049 [Android] Re-evaluate 1-1 conversation upon navigating to it


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

As seen on:

We should have a fallback / safety net for 1:1 migrations.

Solutions

Kalium now exposes a NotifyConversationIsOpenUseCase. This way it can perform sanity checks when it knows that the conversation is visible to the user.

This PR adds a call to the new use case within ConversationBannerViewModel. Ensuring that every time a conversation is opened, Kalium will figure out its magic. Corresponding tests have also been added to validate this functionality.

Dependencies

Needs releases with:

Testing

Test Coverage

  • I have added automated test to this contribution

How to Test

Navigate to any conversation. The UseCase should be called. Kalium will decide whether or not to upgrade protocol.


PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

This update introduces usage of the NotifyConversationIsOpenUseCase within the ConversationBannerViewModel. It ensures that every time a conversation is opened, delegating to Kalium to figure out its magic. Corresponding tests have also been added to validate this functionality.
@vitorhugods vitorhugods requested review from a team, alexandreferris, MohamadJaara, mchenani, ohassine and saleniuk and removed request for a team December 4, 2023 20:42
Copy link
Contributor

github-actions bot commented Dec 4, 2023

Test Results

720 tests  +2   720 ✔️ +2   9m 4s ⏱️ + 1m 49s
100 suites ±0       0 💤 ±0 
100 files   ±0       0 ±0 

Results for commit 7969af1. ± Comparison against base commit 3634957.

Copy link
Contributor

github-actions bot commented Dec 4, 2023

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 2154 succeeded.

The build produced the following APK's:

@vitorhugods vitorhugods merged commit 066dd98 into develop Dec 5, 2023
4 of 5 checks passed
@vitorhugods vitorhugods deleted the feat/mls/reevaluate-protocol-on-demand branch December 5, 2023 14:00
Copy link
Contributor

github-actions bot commented Dec 5, 2023

APKs built during tests are available here. Scroll down to Artifacts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants