chore: remove deprecated by server team events (WPB-5879) #2378

yamilmedina · 2024-01-16T17:26:21Z

PR Submission Checklist for internal contributors

The PR Title
- conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
- contains a reference JIRA issue number like SQPIT-764
- answers the question: If merged, this PR will: ... ³
The PR Description
- is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Dead code not used anymore

Causes (Optional)

Removing team events not sent by server, deprecated.

Solutions

Remove the code and provide a new usecase that can refresh the data for the team id.

Needs release

chore: consume new use case to get fresh team info (WPB-5879) wire-android#2589

Testing

Test Coverage (Optional)

WIP

I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References

https://sparkbox.com/foundry/semantic_commit_messages
https://github.com/wireapp/.github#usage
E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

github-actions · 2024-01-16T17:36:20Z

Test Results

2 222 tests - 627 2 180 ✔️ - 565 10s ⏱️ - 2m 29s
  411 suites -   85     42 💤 -   62
  411 files -   85       0 ❌ ±    0

Results for commit c28f5f5. ± Comparison against base commit 4ac7415.

This pull request removes 2849 and adds 2222 tests. Note that renamed tests count towards both.

PocIntegrationTest ‑ givenApiWhenGettingACMEDirectoriesThenReturnAsExpectedBasedOnNetworkState
PocIntegrationTest ‑ givenEmailAndPasswordWhenLoggingInThenRegisterClientAndLogout
com.wire.kalium.HttpClientConnectionSpecsTest ‑ givenTheHttpClientIsCreated_ThenEnsureOnlySupportedSpecsArePresent[jvm]
com.wire.kalium.api.base.authenticated.notification.AccessUpdateTest ‑ givenPayloadWithAccessRoleAndDeprecatedAccessRoleField_whenDecoding_thenDeprecatedFieldIsPreferred[jvm]
com.wire.kalium.api.base.authenticated.notification.AccessUpdateTest ‑ givenPayloadWithDeprecatedAccessRoleField_whenDecoding_thenSuccess[jvm]
com.wire.kalium.api.base.authenticated.notification.AccessUpdateTest ‑ givenPayload_whenDecoding_thenSuccess[jvm]
com.wire.kalium.api.common.ACMEApiTest ‑ givenNoLocationInHeader_whenCallingSendAcmeRequestApi_theResponseShouldBeConfigureCorrectly[jvm]
com.wire.kalium.api.common.ACMEApiTest ‑ givenNoNonce_whenCallingSendAcmeRequestApi_theResponseShouldBeMissingNonce[jvm]
com.wire.kalium.api.common.ACMEApiTest ‑ whenCallingGetACMEDirectoriesApi_theResponseShouldBeConfigureCorrectly[jvm]
com.wire.kalium.api.common.ACMEApiTest ‑ whenCallingGetACMENonceApi_theResponseShouldBeConfigureCorrectly[jvm]
…

com.wire.kalium.api.base.authenticated.notification.AccessUpdateTest ‑ givenPayloadWithAccessRoleAndDeprecatedAccessRoleField_whenDecoding_thenDeprecatedFieldIsPreferred[iosX64]
com.wire.kalium.api.base.authenticated.notification.AccessUpdateTest ‑ givenPayloadWithDeprecatedAccessRoleField_whenDecoding_thenSuccess[iosX64]
com.wire.kalium.api.base.authenticated.notification.AccessUpdateTest ‑ givenPayload_whenDecoding_thenSuccess[iosX64]
com.wire.kalium.api.common.ACMEApiTest ‑ givenNoLocationInHeader_whenCallingSendAcmeRequestApi_theResponseShouldBeConfigureCorrectly[iosX64]
com.wire.kalium.api.common.ACMEApiTest ‑ givenNoNonce_whenCallingSendAcmeRequestApi_theResponseShouldBeMissingNonce[iosX64]
com.wire.kalium.api.common.ACMEApiTest ‑ whenCallingGetACMEDirectoriesApi_theResponseShouldBeConfigureCorrectly[iosX64]
com.wire.kalium.api.common.ACMEApiTest ‑ whenCallingGetACMENonceApi_theResponseShouldBeConfigureCorrectly[iosX64]
com.wire.kalium.api.common.ACMEApiTest ‑ whenCallingSendAcmeRequestApi_theResponseShouldBeConfigureCorrectly[iosX64]
com.wire.kalium.api.common.ACMEApiTest ‑ whenCallingSendChallengeRequestApi_theResponseShouldBeConfigureCorrectly[iosX64]
com.wire.kalium.api.common.BackendMetaDataUtilTest ‑ givenAnEmptyAppSupportedVersionList_whenCalculateApiVersion_thenTheUnknownServerIsReturned[iosX64]
…

This pull request removes 104 skipped tests and adds 42 skipped tests. Note that renamed tests count towards both.

PocIntegrationTest ‑ givenApiWhenGettingACMEDirectoriesThenReturnAsExpectedBasedOnNetworkState
PocIntegrationTest ‑ givenEmailAndPasswordWhenLoggingInThenRegisterClientAndLogout
com.wire.kalium.api.common.ACMEApiTest ‑ whenCallingSendChallengeRequestApi_theResponseShouldBeConfigureCorrectly[jvm]
com.wire.kalium.api.v0.user.register.RegisterApiV0Test ‑ givenAValidEmail_whenActivationEmailWIthCode_theRequestShouldBeConfiguredCorrectly[jvm]
com.wire.kalium.api.v0.user.register.RegisterApiV0Test ‑ givenAValidEmail_whenRegisteringAccountWithEMail_theRequestShouldBeConfiguredCorrectly[jvm]
com.wire.kalium.api.v0.user.register.RegisterApiV0Test ‑ givenAValidEmail_whenSendingActivationEmail_theRequestShouldBeConfiguredCorrectly[jvm]
com.wire.kalium.api.v0.user.register.RegisterApiV0Test ‑ givenActivationCodeFail_thenErrorIsPropagated[jvm]
com.wire.kalium.api.v0.user.register.RegisterApiV0Test ‑ givenRegistrationFail_whenRegisteringAccountWithEMMail_thenErrorIsPropagated[jvm]
com.wire.kalium.api.v0.user.register.RegisterApiV0Test ‑ givenSendActivationCodeFail_thenErrorIsPropagated[jvm]
com.wire.kalium.cryptography.CryptoUtilsTest ‑ givenDummyText_whenEncryptedAndDecryptedWithAES256_returnsOriginalText[js, browser]
…

com.wire.kalium.api.common.ACMEApiTest ‑ whenCallingSendChallengeRequestApi_theResponseShouldBeConfigureCorrectly[iosX64]
com.wire.kalium.api.v0.message.QualifiedMessageApiV0Test ‑ givenAValid_whenSendingAMessage_theRequestShouldBeConfiguredCorrectly[iosX64]
com.wire.kalium.api.v0.message.QualifiedMessageApiV0Test ‑ givenDeletedUsersError_whenSendingAMessage_TheCorrectErrorIsPropagate[iosX64]
com.wire.kalium.api.v0.message.QualifiedMessageApiV0Test ‑ givenMissingUsersError_whenSendingAMessage_TheCorrectErrorIsPropagate[iosX64]
com.wire.kalium.api.v0.message.QualifiedMessageApiV0Test ‑ givenRedundantUsersError_whenSendingAMessage_TheCorrectErrorIsPropagate[iosX64]
com.wire.kalium.api.v0.user.register.RegisterApiV0Test ‑ givenAValidEmail_whenActivationEmailWIthCode_theRequestShouldBeConfiguredCorrectly[iosX64]
com.wire.kalium.api.v0.user.register.RegisterApiV0Test ‑ givenAValidEmail_whenRegisteringAccountWithEMail_theRequestShouldBeConfiguredCorrectly[iosX64]
com.wire.kalium.api.v0.user.register.RegisterApiV0Test ‑ givenAValidEmail_whenSendingActivationEmail_theRequestShouldBeConfiguredCorrectly[iosX64]
com.wire.kalium.api.v0.user.register.RegisterApiV0Test ‑ givenActivationCodeFail_thenErrorIsPropagated[iosX64]
com.wire.kalium.api.v0.user.register.RegisterApiV0Test ‑ givenRegistrationFail_whenRegisteringAccountWithEMMail_thenErrorIsPropagated[iosX64]
…

♻️ This comment has been updated with latest results.

codecov-commenter · 2024-01-16T18:00:46Z

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (b16d0fd) 58.72% compared to head (c28f5f5) 58.73%.
Report is 1 commits behind head on develop.

Additional details and impacted files

@@              Coverage Diff              @@
##             develop    #2378      +/-   ##
=============================================
+ Coverage      58.72%   58.73%   +0.01%     
  Complexity        21       21              
=============================================
  Files           1118     1118              
  Lines          43884    43777     -107     
  Branches        4090     4084       -6     
=============================================
- Hits           25771    25714      -57     
+ Misses         16299    16249      -50     
  Partials        1814     1814

Files	Coverage Δ
...um/logic/feature/conversation/ConversationScope.kt	`0.00% <ø> (ø)`
...re/kalium/logic/sync/incremental/EventProcessor.kt	`67.56% <100.00%> (ø)`
...base/authenticated/notification/EventContentDTO.kt	`55.64% <ø> (+1.79%)`	⬆️
...um/logic/feature/team/GetUpdatedSelfTeamUseCase.kt	`85.71% <85.71%> (ø)`
...re/kalium/logic/sync/receiver/TeamEventReceiver.kt	`96.00% <50.00%> (+12.66%)`	⬆️
...in/com/wire/kalium/logic/data/event/EventMapper.kt	`21.76% <50.00%> (+0.96%)`	⬆️
...in/com/wire/kalium/logic/feature/team/TeamScope.kt	`0.00% <0.00%> (ø)`
...n/kotlin/com/wire/kalium/logic/data/event/Event.kt	`76.91% <0.00%> (-1.04%)`	⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ac7415...c28f5f5. Read the comment docs.

datadog-wireapp · 2024-01-16T18:01:04Z

Datadog Report

All test runs c334329 🔗

✅ 2 Total Test Services: 0 Failed, 2 Passed

Test Services

Service Name	Failed	Known Flaky	New Flaky	Passed	Skipped	Wall Time	Test Service View
`kalium-ios`	0	0	0	2180	42	6m 35.13s	Link
`kalium-jvm`	0	0	0	2746	104	8m 43.01s	Link

alexandreferris

Just commenting out if we can test it 🤔

logic/src/commonTest/kotlin/com/wire/kalium/logic/feature/team/GetUpdatedSelfTeamUseCaseTest.kt

alexandreferris

👌🏻

MohamadJaara

LGTM, we just need to wait until #2374 is merged to avoid a lot of conflicts

yamilmedina added 5 commits January 16, 2024 14:32

chore: removing deprecated events

80fc6db

chore: deteket

128ee9c

chore: create use case to get updated from server team info

86e25e8

chore: create use case to get updated from server team info

306335d

chore: create use case to get updated from server team info

bf5132e

yamilmedina self-assigned this Jan 16, 2024

github-actions bot added 🚨 Potential breaking changes type: chore 🧹 👕 size: L labels Jan 16, 2024

Merge branch 'develop' into chore/remove-deprecated-by-server-events

9265543

yamilmedina mentioned this pull request Jan 16, 2024

chore: consume new use case to get fresh team info (WPB-5879) wireapp/wire-android#2589

Merged

7 tasks

Merge branch 'develop' into chore/remove-deprecated-by-server-events

02b2f7f

yamilmedina requested review from MohamadJaara, a team, typfel, vitorhugods, mchenani, ohassine and alexandreferris and removed request for a team January 16, 2024 17:39

yamilmedina added 2 commits January 16, 2024 19:49

Merge branch 'develop' into chore/remove-deprecated-by-server-events

e48409c

chore: clean up not needed keys for log

2a58566

alexandreferris reviewed Jan 17, 2024

View reviewed changes

logic/src/commonTest/kotlin/com/wire/kalium/logic/feature/team/GetUpdatedSelfTeamUseCaseTest.kt Outdated Show resolved Hide resolved

chore: adding tests cov

9d3e205

github-actions bot added 👕 size: XL and removed 👕 size: L labels Jan 17, 2024

alexandreferris approved these changes Jan 17, 2024

View reviewed changes

chore: adding tests cov

e22c26e

MohamadJaara approved these changes Jan 17, 2024

View reviewed changes

yamilmedina added 3 commits January 17, 2024 14:19

Merge branch 'develop' into chore/remove-deprecated-by-server-events

95f0507

chore: fix conflicts

0c4479f

chore: fix conflics

c28f5f5

github-actions bot added 👕 size: L and removed 👕 size: XL labels Jan 17, 2024

yamilmedina enabled auto-merge January 17, 2024 13:33

yamilmedina added this pull request to the merge queue Jan 17, 2024

Merged via the queue into develop with commit 93b5f3d Jan 17, 2024
17 checks passed

yamilmedina deleted the chore/remove-deprecated-by-server-events branch January 17, 2024 14:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: remove deprecated by server team events (WPB-5879) #2378

chore: remove deprecated by server team events (WPB-5879) #2378

yamilmedina commented Jan 16, 2024 •

edited

github-actions bot commented Jan 16, 2024 •

edited

codecov-commenter commented Jan 16, 2024 •

edited

datadog-wireapp bot commented Jan 16, 2024 •

edited

alexandreferris left a comment

alexandreferris left a comment

MohamadJaara left a comment

chore: remove deprecated by server team events (WPB-5879) #2378

chore: remove deprecated by server team events (WPB-5879) #2378

Conversation

yamilmedina commented Jan 16, 2024 • edited

PR Submission Checklist for internal contributors

What's new in this PR?

Issues

Causes (Optional)

Solutions

Needs release

Testing

Test Coverage (Optional)

PR Post Submission Checklist for internal contributors (Optional)

PR Post Merge Checklist for internal contributors

References

github-actions bot commented Jan 16, 2024 • edited

Test Results

codecov-commenter commented Jan 16, 2024 • edited

Codecov Report

datadog-wireapp bot commented Jan 16, 2024 • edited

Datadog Report

alexandreferris left a comment

Choose a reason for hiding this comment

alexandreferris left a comment

Choose a reason for hiding this comment

MohamadJaara left a comment

Choose a reason for hiding this comment

yamilmedina commented Jan 16, 2024 •

edited

github-actions bot commented Jan 16, 2024 •

edited

codecov-commenter commented Jan 16, 2024 •

edited

datadog-wireapp bot commented Jan 16, 2024 •

edited