Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: consume new use case to get fresh team info (WPB-5879) #2589

Merged
merged 7 commits into from Jan 17, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Jan 16, 2024

TaskWPB-5879 [Android] remove team.update and team.member-update events


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Dead code not used anymore

Causes (Optional)

Removing team events not sent by server, deprecated.

Solutions

Remove the code and provide a new usecase that can refresh the data for the team id.

Depends on

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina requested review from a team, alexandreferris, borichellow, MohamadJaara, Garzas and saleniuk and removed request for a team January 16, 2024 17:39
Copy link
Contributor

github-actions bot commented Jan 16, 2024

Test Results

744 tests   744 ✅  10m 50s ⏱️
102 suites    0 💤
102 files      0 ❌

Results for commit 0856ab1.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 2599 failed.

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 74 lines in your changes are missing coverage. Please review.

Comparison is base (b15453f) 41.39% compared to head (0856ab1) 41.31%.
Report is 5 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2589      +/-   ##
=============================================
- Coverage      41.39%   41.31%   -0.08%     
- Complexity      1129     1130       +1     
=============================================
  Files            361      364       +3     
  Lines          13255    13316      +61     
  Branches        1742     1747       +5     
=============================================
+ Hits            5487     5502      +15     
- Misses          7236     7283      +47     
+ Partials         532      531       -1     
Files Coverage Δ
.../android/ui/authentication/devices/model/Device.kt 95.00% <100.00%> (+0.55%) ⬆️
...droid/ui/home/messagecomposer/AttachmentOptions.kt 0.00% <ø> (ø)
.../messagecomposer/state/MessageCompositionHolder.kt 33.62% <100.00%> (+1.50%) ⬆️
...tions/details/GroupConversationDetailsViewModel.kt 60.67% <66.66%> (ø)
.../ui/home/conversations/MessageComposerViewModel.kt 81.96% <71.42%> (+0.30%) ⬆️
...ndroid/ui/settings/devices/SelfDevicesViewModel.kt 85.29% <60.00%> (-2.21%) ⬇️
...messagecomposer/state/AdditionalOptionMenuState.kt 43.75% <25.00%> (-1.71%) ⬇️
...e/android/ui/home/conversations/model/UIMessage.kt 47.30% <20.00%> (+0.13%) ⬆️
...home/messagecomposer/location/GeoLocatedAddress.kt 0.00% <0.00%> (ø)
...essagecomposer/state/MessageComposerStateHolder.kt 55.55% <0.00%> (-5.06%) ⬇️
... and 5 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cd101e...0856ab1. Read the comment docs.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 2600 succeeded.

The build produced the following APK's:

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@yamilmedina yamilmedina added this pull request to the merge queue Jan 17, 2024
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 2621 succeeded.

The build produced the following APK's:

Merged via the queue into develop with commit ed02ade Jan 17, 2024
14 of 15 checks passed
@yamilmedina yamilmedina deleted the chore/remove-deprecated-by-server-events branch January 17, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants