Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fetch MLS config when not available locally [WPB-8592] 🍒 #2744

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 7, 2024

StoryWPB-8592 [Android] Add support for ECDSA ciphersuites

This PR was automatically cherry-picked based on the following PR:

Original PR description:



PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

creating an MLS client needs MLS feature config from the backend

Solutions

when the config is not stored locally fetch it from remote

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

…into feat/pass-signature-algorithm-when-registring-mls-client-cherry-pick

# Conflicts:
#	cryptography/src/commonJvmAndroid/kotlin/com.wire.kalium.cryptography/MLSClientImpl.kt
#	logic/src/commonMain/kotlin/com/wire/kalium/logic/data/mls/CipherSuite.kt
Signed-off-by: MohamadJaara <mohamad.jaara@wire.com>
@MohamadJaara MohamadJaara changed the base branch from release/candidate to chore/update-CC-to-RC-59-cherry-pick May 18, 2024 06:47
@MohamadJaara MohamadJaara changed the title feat: fetch MLS config when not available locally 🍒 feat: fetch MLS config when not available locally [WPB-8592] 🍒 May 18, 2024
…g-mls-client-cherry-pick' into chore/update-CC-to-RC-59-cherry-pick

# Conflicts:
#	gradle/libs.versions.toml
@MohamadJaara MohamadJaara force-pushed the chore/update-CC-to-RC-59-cherry-pick branch from c494dcc to 614244e Compare May 18, 2024 07:35
…RC-59-cherry-pick' into fix/fetch-MLS-config-when-not-avilable-locally-cherry-pick

# Conflicts:
#	cryptography/src/androidInstrumentedTest/kotlin/com/wire/kalium/cryptography/BaseMLSClientTest.kt
#	cryptography/src/androidUnitTest/kotlin/com/wire/kalium/cryptography/BaseMLSClientTest.kt
#	cryptography/src/appleMain/kotlin/com/wire/kalium/cryptography/CoreCryptoCentralImpl.kt
#	cryptography/src/appleTest/kotlin/com/wire/kalium/cryptography/BaseMLSClientTest.kt
#	cryptography/src/commonJvmAndroid/kotlin/com.wire.kalium.cryptography/CoreCryptoCentral.kt
#	cryptography/src/commonMain/kotlin/com/wire/kalium/cryptography/CoreCryptoCentral.kt
#	cryptography/src/commonTest/kotlin/com/wire/kalium/cryptography/BaseMLSClientTest.kt
#	cryptography/src/jsMain/kotlin/com/wire/kalium/cryptography/CoreCryptoCentralImpl.kt
#	cryptography/src/jsTest/kotlin/com/wire/kalium/cryptography/BaseMLSClientTest.kt
#	cryptography/src/jvmTest/kotlin/com/wire/kalium/cryptography/BaseMLSClientTest.kt
#	cryptography/src/jvmTest/kotlin/com/wire/kalium/cryptography/BaseProteusClientTest.kt
#	logic/src/commonMain/kotlin/com/wire/kalium/logic/data/client/MLSClientProvider.kt
#	logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/UserSessionScope.kt
#	logic/src/commonTest/kotlin/com/wire/kalium/logic/util/arrangement/repository/UserConfigRepositoryArrangement.kt
Signed-off-by: MohamadJaara <mohamad.jaara@wire.com>
…S-config-when-not-avilable-locally-cherry-pick
Copy link
Contributor Author

github-actions bot commented May 18, 2024

Test Results

3 043 tests   2 939 ✔️  3m 8s ⏱️
   529 suites     104 💤
   529 files           0

Results for commit 9ba72e7.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented May 18, 2024

Datadog Report

Branch report: fix/fetch-MLS-config-when-not-avilable-locally-cherry-pick
Commit report: bb5e9bf
Test service: kalium-jvm

✅ 0 Failed, 1 Passed, 0 Skipped, 0s Total Time

Base automatically changed from chore/update-CC-to-RC-59-cherry-pick to release/candidate May 21, 2024 07:17
@MohamadJaara MohamadJaara enabled auto-merge (squash) May 21, 2024 07:18
Copy link

sonarcloud bot commented May 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@MohamadJaara MohamadJaara merged commit f8c4a14 into release/candidate May 21, 2024
19 checks passed
@MohamadJaara MohamadJaara deleted the fix/fetch-MLS-config-when-not-avilable-locally-cherry-pick branch May 21, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants