Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fetch MLS config when not available locally [WPB-8592] 🍒 🍒 #2778

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 21, 2024

StoryWPB-8592 [Android] Add support for ECDSA ciphersuites

This PR was automatically cherry-picked based on the following PR:

Original PR description:


This PR was automatically cherry-picked based on the following PR:

Original PR description:



PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

creating an MLS client needs MLS feature config from the backend

Solutions

when the config is not stored locally fetch it from remote

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@MohamadJaara MohamadJaara changed the base branch from develop to chore/update-CC-to-RC-59-cherry-pick-cherry-pick May 29, 2024 13:13
Base automatically changed from chore/update-CC-to-RC-59-cherry-pick-cherry-pick to develop June 3, 2024 08:06
…etch-MLS-config-when-not-avilable-locally-cherry-pick-cherry-pick

# Conflicts:
#	cryptography/src/androidInstrumentedTest/kotlin/com/wire/kalium/cryptography/BaseMLSClientTest.kt
#	cryptography/src/androidUnitTest/kotlin/com/wire/kalium/cryptography/BaseMLSClientTest.kt
#	cryptography/src/appleMain/kotlin/com/wire/kalium/cryptography/CoreCryptoCentralImpl.kt
#	cryptography/src/appleTest/kotlin/com/wire/kalium/cryptography/BaseMLSClientTest.kt
#	cryptography/src/commonJvmAndroid/kotlin/com.wire.kalium.cryptography/CoreCryptoCentral.kt
#	cryptography/src/commonMain/kotlin/com/wire/kalium/cryptography/CoreCryptoCentral.kt
#	cryptography/src/commonTest/kotlin/com/wire/kalium/cryptography/BaseMLSClientTest.kt
#	cryptography/src/jsMain/kotlin/com/wire/kalium/cryptography/CoreCryptoCentralImpl.kt
#	cryptography/src/jsTest/kotlin/com/wire/kalium/cryptography/BaseMLSClientTest.kt
#	cryptography/src/jvmTest/kotlin/com/wire/kalium/cryptography/BaseMLSClientTest.kt
#	cryptography/src/jvmTest/kotlin/com/wire/kalium/cryptography/BaseProteusClientTest.kt
#	logic/src/commonMain/kotlin/com/wire/kalium/logic/data/client/MLSClientProvider.kt
#	logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/UserSessionScope.kt
#	logic/src/commonTest/kotlin/com/wire/kalium/logic/util/arrangement/repository/UserConfigRepositoryArrangement.kt
Copy link
Contributor Author

github-actions bot commented Jun 3, 2024

Test Results

3 058 tests  +2   2 954 ✔️ +2   2m 59s ⏱️ ±0s
   530 suites +1      104 💤 ±0 
   530 files   +1          0 ±0 

Results for commit 2f2060b. ± Comparison against base commit d262344.

♻️ This comment has been updated with latest results.

@MohamadJaara MohamadJaara force-pushed the fix/fetch-MLS-config-when-not-avilable-locally-cherry-pick-cherry-pick branch from 9f50cb1 to 9abc6cf Compare June 3, 2024 20:42
@datadog-wireapp
Copy link

datadog-wireapp bot commented Jun 3, 2024

Datadog Report

Branch report: fix/fetch-MLS-config-when-not-avilable-locally-cherry-pick-cherry-pick
Commit report: 9b6237f
Test service: kalium-jvm

✅ 0 Failed, 2954 Passed, 104 Skipped, 9.28s Total Time

Copy link

sonarcloud bot commented Jun 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@MohamadJaara MohamadJaara added this pull request to the merge queue Jun 4, 2024
Merged via the queue into develop with commit 7f3ce95 Jun 4, 2024
21 checks passed
@MohamadJaara MohamadJaara deleted the fix/fetch-MLS-config-when-not-avilable-locally-cherry-pick-cherry-pick branch June 4, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants