Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong pointerInput invoked on scroll inside message list [WPB-3525] #2021

Merged
merged 3 commits into from
Jul 28, 2023

Conversation

trOnk12
Copy link
Contributor

@trOnk12 trOnk12 commented Jul 28, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

  • When scrolling up in the conversation list and back to bottom, the click and onlong click lambda did not get updated, causing the lambda to invoke functions with misplaced data.

Solutions

  • Update pointerInput with each change of text layout.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@CLAassistant
Copy link

CLAassistant commented Jul 28, 2023

CLA assistant check
All committers have signed the CLA.

@trOnk12 trOnk12 changed the base branch from develop to release/candidate July 28, 2023 11:28
@github-actions
Copy link
Contributor

@trOnk12 looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (release/candidate) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

release/candidate This PR
d42a5fd2275d8f23be3b7d0bff9335ff4c87edfc 67514c7ec1394fbb477c9c3fb92600838f2642a5

Is this intentional?

@trOnk12 trOnk12 changed the title fix: wrong pointerInput invoked on scroll inside message list fix: wrong pointerInput invoked on scroll inside message list [WPB-3525] Jul 28, 2023
@trOnk12 trOnk12 requested review from Garzas, a team, gongracr, yamilmedina, borichellow and mchenani and removed request for a team July 28, 2023 11:36
@trOnk12 trOnk12 enabled auto-merge (squash) July 28, 2023 11:44
@github-actions
Copy link
Contributor

Test Results

511 tests   510 ✔️  22s ⏱️
  74 suites      1 💤
  74 files        0

Results for commit 40953a0.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@tmspzz tmspzz disabled auto-merge July 28, 2023 12:01
@tmspzz tmspzz enabled auto-merge (squash) July 28, 2023 12:02
@AndroidBob
Copy link
Collaborator

Build 749 succeeded.

The build produced the following APK's:

@tmspzz tmspzz merged commit c109bf9 into release/candidate Jul 28, 2023
11 of 13 checks passed
@tmspzz tmspzz deleted the fix/wrong_long_click branch July 28, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
6 participants