Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong pointerInput invoked on scroll inside message list [WPB-3525] #2022

Merged
merged 3 commits into from
Jul 31, 2023

Conversation

github-actions[bot]
Copy link
Contributor

Cherry pick from the original PR:



PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

  • When scrolling up in the conversation list and back to bottom, the click and onlong click lambda did not get updated, causing the lambda to invoke functions with misplaced data.

Solutions

  • Update pointerInput with each change of text layout.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions github-actions bot added the cherry-pick PR is cherry-picking changes from another banch label Jul 28, 2023
@CLAassistant
Copy link

CLAassistant commented Jul 28, 2023

CLA assistant check
All committers have signed the CLA.

@AndroidBob
Copy link
Collaborator

Build 753 succeeded.

The build produced the following APK's:

@github-actions
Copy link
Contributor Author

github-actions bot commented Jul 29, 2023

Test Results

518 tests  ±0   517 ✔️ ±0   23s ⏱️ +4s
  75 suites ±0       1 💤 ±0 
  75 files   ±0       0 ±0 

Results for commit b5fdd29. ± Comparison against base commit 1244ad5.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor Author

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 764 succeeded.

The build produced the following APK's:

@tmspzz tmspzz enabled auto-merge July 31, 2023 09:43
@tmspzz tmspzz added this pull request to the merge queue Jul 31, 2023
@github-actions
Copy link
Contributor Author

APKs built during tests are available here. Scroll down to Artifacts!

Merged via the queue into develop with commit f2182c9 Jul 31, 2023
11 of 13 checks passed
@tmspzz tmspzz deleted the fix/wrong_long_click-cherry-pick branch July 31, 2023 10:06
@AndroidBob
Copy link
Collaborator

Build 769 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch size/XS
Projects
None yet
5 participants