fix: line break unhandled event (WPB-3320) #2043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
APKs built during tests are available here. Scroll down to Artifacts! |
alexandreferris
requested review from
a team,
typfel,
borichellow,
MohamadJaara,
vitorhugods and
mchenani
and removed request for
a team
ohassine
approved these changes
Aug 2, 2023
app/src/main/kotlin/com/wire/android/ui/markdown/MarkdownComposer.kt
Outdated
Show resolved
Hide resolved
|
APKs built during tests are available here. Scroll down to Artifacts! |
vitorhugods
approved these changes
Aug 2, 2023
| @@ -158,9 +159,8 @@ fun inlineChildren( | |||
| annotatedString.pop() | |||
| } | |||
|
|
|||
| is HardLineBreak -> { | |||
| is HardLineBreak, is SoftLineBreak -> { | |||
There was a problem hiding this comment.
That is a blessing from commonmark. I wasn't expecting it to be so simple!
Nice find.
|
Build 838 succeeded. The build produced the following APK's: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
When sending a message with 2 lines, the soft line break was not being handled and rendering first and second line together. example:
Causes (Optional)
SoftLineBreakwas not being handled.Solutions
Add handling of
SoftLineBreakso it renders correctly (as in the image below)Testing
How to Test
Attachments (Optional)