Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: line break unhandled event (WPB-3320) #2046

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 2, 2023

Cherry pick from the original PR:



PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

When sending a message with 2 lines, the soft line break was not being handled and rendering first and second line together. example:


Causes (Optional)

SoftLineBreak was not being handled.

Solutions

Add handling of SoftLineBreak so it renders correctly (as in the image below)

Testing

How to Test

  • Open App
  • Open Conversation
  • Receive a message like this:
message1
message2

message 3
  • Should be handled as 3 correct lines and not only 2

Attachments (Optional)

@github-actions github-actions bot added the cherry-pick PR is cherry-picking changes from another banch label Aug 2, 2023
@alexandreferris alexandreferris requested review from ohassine and vitorhugods and removed request for ohassine August 2, 2023 14:06
@github-actions
Copy link
Contributor Author

github-actions bot commented Aug 2, 2023

Test Results

519 tests  ±0   518 ✔️ ±0   23s ⏱️ ±0s
  75 suites ±0       1 💤 ±0 
  75 files   ±0       0 ±0 

Results for commit 02ed74b. ± Comparison against base commit 7503f6f.

@github-actions
Copy link
Contributor Author

github-actions bot commented Aug 2, 2023

APKs built during tests are available here. Scroll down to Artifacts!

@alexandreferris alexandreferris added this pull request to the merge queue Aug 2, 2023
@AndroidBob
Copy link
Collaborator

Build 843 succeeded.

The build produced the following APK's:

Merged via the queue into develop with commit 044c34e Aug 2, 2023
13 checks passed
@alexandreferris alexandreferris deleted the fix/line_break_unhandled_event-cherry-pick branch August 2, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch size/XS
Projects
None yet
5 participants