Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change the connectivtiy message #2100

Merged
merged 32 commits into from
Aug 15, 2023
Merged

Conversation

trOnk12
Copy link
Contributor

@trOnk12 trOnk12 commented Aug 14, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

  • Change the label for connectivity status bar when going through the sync process
  • Move the functions up in the class to make them following usage of them abit easier.

Attachments (Optional)

image

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 14, 2023

Test Results

541 tests  ±0   540 ✔️ ±0   5m 31s ⏱️ +29s
  80 suites ±0       1 💤 ±0 
  80 files   ±0       0 ±0 

Results for commit cfc35c4. ± Comparison against base commit 7e00519.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 1085 failed.

@pull-request-size pull-request-size bot added size/M and removed size/L labels Aug 14, 2023
@AndroidBob
Copy link
Collaborator

Build 1086 failed.

@AndroidBob
Copy link
Collaborator

Build 1102 succeeded.

The build produced the following APK's:

@ohassine ohassine added this pull request to the merge queue Aug 15, 2023
@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Merged via the queue into develop with commit 34ca0ab Aug 15, 2023
16 checks passed
@ohassine ohassine deleted the fix/change_connectivity_String branch August 15, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants