Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change the connectivity message (RC) #2102

Merged
merged 2 commits into from
Aug 15, 2023

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Aug 15, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Sister PR of #2100

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine requested review from a team, gongracr, yamilmedina, vitorhugods, mchenani and trOnk12 and removed request for a team August 15, 2023 13:14
@MohamadJaara MohamadJaara enabled auto-merge (squash) August 15, 2023 13:25
@github-actions
Copy link
Contributor

Test Results

542 tests   541 ✔️  24s ⏱️
  77 suites      1 💤
  77 files        0

Results for commit 014a520.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1103 succeeded.

The build produced the following APK's:

@MohamadJaara MohamadJaara merged commit 58341a1 into release/candidate Aug 15, 2023
17 of 18 checks passed
@MohamadJaara MohamadJaara deleted the fix/change_connectivity_String_rc branch August 15, 2023 13:50
github-actions bot pushed a commit that referenced this pull request Aug 15, 2023
Co-authored-by: Mateusz <m.pachulski94@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
6 participants