fix: remove conversations title on import media screen [WPB-1860] #2108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 1148 succeeded. The build produced the following APK's: |
saleniuk
requested review from
a team,
gongracr,
yamilmedina,
alexandreferris,
borichellow and
ohassine
and removed request for
a team and
gongracr
yamilmedina
approved these changes
Aug 16, 2023
MohamadJaara
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
On "share media" screen, on the top of the conversation list, there is a title bar called “Conversations”. There should be no such bar as this takes up space which is needed when the keyboard is open, by tapping into the search field.
Causes (Optional)
We're reusing the same element to show conversation list.
Solutions
Make
headeroptional, so that if it's not provided, it won't add it to the list.Testing
How to Test
Share some media into the Wire.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.