Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove conversations title on import media screen [WPB-1860] #2111

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

github-actions[bot]
Copy link
Contributor

Cherry pick from the original PR:


⚠️ Conflicts during cherry-pick:


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

On "share media" screen, on the top of the conversation list, there is a title bar called “Conversations”. There should be no such bar as this takes up space which is needed when the keyboard is open, by tapping into the search field.

Causes (Optional)

We're reusing the same element to show conversation list.

Solutions

Make header optional, so that if it's not provided, it won't add it to the list.

Testing

How to Test

Share some media into the Wire.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)

Before After   
before after

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions github-actions bot added the cherry-pick PR is cherry-picking changes from another banch label Aug 17, 2023
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #2111 (253f714) into develop (02e5794) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #2111      +/-   ##
=============================================
- Coverage      40.35%   40.35%   -0.01%     
  Complexity       956      956              
=============================================
  Files            305      305              
  Lines          11307    11308       +1     
  Branches        1516     1516              
=============================================
  Hits            4563     4563              
- Misses          6307     6308       +1     
  Partials         437      437              
Files Changed Coverage Δ
...home/conversationslist/model/ConversationFolder.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02e5794...253f714. Read the comment docs.

@github-actions
Copy link
Contributor Author

Test Results

555 tests  ±0   554 ✔️ ±0   6m 13s ⏱️ -16s
  80 suites ±0       1 💤 ±0 
  80 files   ±0       0 ±0 

Results for commit 253f714. ± Comparison against base commit 02e5794.

@github-actions
Copy link
Contributor Author

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1163 succeeded.

The build produced the following APK's:

@tmspzz tmspzz enabled auto-merge August 17, 2023 11:37
@tmspzz tmspzz added this pull request to the merge queue Aug 17, 2023
Merged via the queue into develop with commit 37d7257 Aug 17, 2023
13 checks passed
@tmspzz tmspzz deleted the fix/remove-conv-title-on-import-screen-cherry-pick branch August 17, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch size/M
Projects
None yet
4 participants