Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: spannable link in markdown #2118

Merged
merged 2 commits into from
Aug 18, 2023
Merged

fix: spannable link in markdown #2118

merged 2 commits into from
Aug 18, 2023

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Aug 18, 2023

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Last sign was not spanned

Attachments like images, videos, etc. (drag and drop in the text box)

Before After
before after

@Garzas Garzas requested review from saleniuk and a team August 18, 2023 13:29
@Garzas Garzas self-assigned this Aug 18, 2023
@Garzas Garzas requested review from typfel, gongracr, yamilmedina and trOnk12 and removed request for a team August 18, 2023 13:29
@github-actions
Copy link
Contributor

github-actions bot commented Aug 18, 2023 •
edited

Test Results

545 tests   544 ✔️  22s ⏱️
  77 suites      1 💤
  77 files        0 ❌

Results for commit 5c94016.

♻️ This comment has been updated with latest results.

@Garzas Garzas enabled auto-merge (squash) August 18, 2023 13:41
@AndroidBob
Copy link
Collaborator

Build 1191 failed.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1193 succeeded.

The build produced the following APK's:

@Garzas Garzas merged commit ec6c6b9 into release/candidate Aug 18, 2023
13 checks passed
@Garzas Garzas deleted the fix/spannable-link branch August 18, 2023 14:23
github-actions bot pushed a commit that referenced this pull request Aug 18, 2023
@Garzas @github-actions
fix: spannable link in markdown (#2118)
95653e5
@github-actions github-actions bot mentioned this pull request Aug 18, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmspzz tmspzz tmspzz approved these changes

@yamilmedina yamilmedina yamilmedina approved these changes

@saleniuk saleniuk Awaiting requested review from saleniuk

@typfel typfel Awaiting requested review from typfel typfel was automatically assigned from wireapp/android

@gongracr gongracr Awaiting requested review from gongracr gongracr was automatically assigned from wireapp/android

@trOnk12 trOnk12 Awaiting requested review from trOnk12 trOnk12 was automatically assigned from wireapp/android

Assignees

@Garzas Garzas

Labels
size/L
Projects
None yet
Milestone
No milestone
4 participants
@Garzas @AndroidBob @tmspzz @yamilmedina