Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: spannable link in markdown #2119

Merged
merged 3 commits into from
Aug 21, 2023
Merged

fix: spannable link in markdown #2119

merged 3 commits into from
Aug 21, 2023

Conversation

github-actions[bot]
Copy link
Contributor

Cherry pick from the original PR:

⚠️ Conflicts during cherry-pick:

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Last sign was not spanned

Attachments like images, videos, etc. (drag and drop in the text box)

Before After
before after

@github-actions github-actions bot added the cherry-pick PR is cherry-picking changes from another banch label Aug 18, 2023
@AndroidBob
Copy link
Collaborator

Build 1195 failed.

@Garzas Garzas requested review from vitorhugods and saleniuk and removed request for vitorhugods August 21, 2023 06:49
@github-actions
Copy link
Contributor Author

github-actions bot commented Aug 21, 2023 •
edited

Test Results

572 tests  ±0   571 ✔️ ±0   6m 26s ⏱️ - 1m 11s
  83 suites ±0       1 💤 ±0 
  83 files   ±0       0 ❌ ±0 

Results for commit fb45902. ± Comparison against base commit 36ff8db.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 1201 failed.

@Garzas Garzas requested review from a team, alexandreferris, borichellow, MohamadJaara and vitorhugods and removed request for a team August 21, 2023 09:00
@Garzas Garzas enabled auto-merge August 21, 2023 09:17
@Garzas Garzas added this pull request to the merge queue Aug 21, 2023
@github-actions
Copy link
Contributor Author

APKs built during tests are available here. Scroll down to Artifacts!

Merged via the queue into develop with commit 65457e5 Aug 21, 2023
12 of 13 checks passed
@Garzas Garzas deleted the fix/spannable-link-cherry-pick branch August 21, 2023 09:40
@AndroidBob
Copy link
Collaborator

Build 1204 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yamilmedina yamilmedina yamilmedina approved these changes

@MohamadJaara MohamadJaara MohamadJaara approved these changes

@mchenani mchenani mchenani approved these changes

@saleniuk saleniuk Awaiting requested review from saleniuk

@alexandreferris alexandreferris Awaiting requested review from alexandreferris alexandreferris was automatically assigned from wireapp/android

@borichellow borichellow Awaiting requested review from borichellow borichellow was automatically assigned from wireapp/android

@vitorhugods vitorhugods Awaiting requested review from vitorhugods vitorhugods was automatically assigned from wireapp/android

Assignees

@Garzas Garzas

Labels
cherry-pick PR is cherry-picking changes from another banch size/L
Projects
None yet
Milestone
No milestone
5 participants
@AndroidBob @yamilmedina @MohamadJaara @mchenani @Garzas