-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: missing username and avatar for first message after creating goup [WPB-3557] #2125
Merged
saleniuk
merged 3 commits into
release/candidate
from
fix/missing-username-after-system-message
Aug 23, 2023
Merged
fix: missing username and avatar for first message after creating goup [WPB-3557] #2125
saleniuk
merged 3 commits into
release/candidate
from
fix/missing-username-after-system-message
Aug 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
APKs built during tests are available here. Scroll down to Artifacts! |
Build 1216 succeeded. The build produced the following APK's: |
borichellow
approved these changes
Aug 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice one!
yamilmedina
approved these changes
Aug 22, 2023
APKs built during tests are available here. Scroll down to Artifacts! |
Build 1227 succeeded. The build produced the following APK's: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
There is no header with sender name and avatar after creating a group. It probably applies to all situations when user is the sender of a system message and then creates a regular message.
Solutions
Check also types of messages when grouping messages.
Method is extracted to
AuthorHeaderHelper
for easier testing.Testing
Test Coverage (Optional)
How to Test
Create a group and then send a message.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.