Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing username and avatar for first message after creating goup [WPB-3557] #2125

Merged
merged 3 commits into from
Aug 23, 2023

Conversation

saleniuk
Copy link
Contributor


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

There is no header with sender name and avatar after creating a group. It probably applies to all situations when user is the sender of a system message and then creates a regular message.

Solutions

Check also types of messages when grouping messages.
Method is extracted to AuthorHeaderHelper for easier testing.

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Create a group and then send a message.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2023

Test Results

556 tests   555 ✔️  22s ⏱️
  78 suites      1 💤
  78 files        0

Results for commit e21c196.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1216 succeeded.

The build produced the following APK's:

Copy link
Contributor

@borichellow borichellow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one!

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1227 succeeded.

The build produced the following APK's:

@saleniuk saleniuk merged commit 5a4e6eb into release/candidate Aug 23, 2023
13 checks passed
@saleniuk saleniuk deleted the fix/missing-username-after-system-message branch August 23, 2023 09:45
github-actions bot pushed a commit that referenced this pull request Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants