fix: missing username and avatar for first message after creating goup [WPB-3557] #2129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
the
cherry-pick
|
Build 1233 failed. |
|
Build 1235 failed. |
|
Build 1237 succeeded. The build produced the following APK's: |
ohassine
approved these changes
Aug 23, 2023
|
APKs built during tests are available here. Scroll down to Artifacts! |
saleniuk
requested review from
a team,
typfel,
gongracr,
borichellow,
MohamadJaara and
trOnk12
and removed request for
a team
alexandreferris
approved these changes
Aug 24, 2023
alexandreferris
deleted the
fix/missing-username-after-system-message-cherry-pick
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick from the original PR:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
There is no header with sender name and avatar after creating a group. It probably applies to all situations when user is the sender of a system message and then creates a regular message.
Solutions
Check also types of messages when grouping messages.
Method is extracted to
AuthorHeaderHelperfor easier testing.Testing
Test Coverage (Optional)
How to Test
Create a group and then send a message.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.