Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: conversation screen top bar spacing [WPB-971] #2195

Merged
merged 5 commits into from
Sep 11, 2023
Merged

fix: conversation screen top bar spacing [WPB-971] #2195

merged 5 commits into from
Sep 11, 2023

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Sep 7, 2023

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Current usage of space on the conversation screen top bar is not optimal and not much of the conversation title fits on the screen.

Solutions

Decrease spacing between top bar elements, reduce buttons widths, title font size and avatar size.
To make it possible to narrow the buttons, LocalMinimumInteractiveComponentEnforcement is disabled for WireButton (it makes the clickable elements to have minimal dimensions required by system) and instead, new parameter minClickableSize is provided to be able to apply custom values to that. Also, minWidth and minHeight are grouped into minSize to keep consistency and all hardcoded button sizes are replaced with values defined in WireDimensions.

Attachments (Optional)

Before After
conversation_topbar_before conversation_topbar_after

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.
References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023 •
edited

Test Results

587 tests   586 ✔️  6m 40s ⏱️
  84 suites      1 💤
  84 files        0 ❌

Results for commit 2ea10f1.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 630 failed.

@AndroidBob
Copy link
Collaborator

Build 633 succeeded.

The build produced the following APK's:

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

APKs built during tests are available here. Scroll down to Artifacts!

@saleniuk saleniuk requested review from a team, typfel, gongracr, borichellow, vitorhugods and ohassine and removed request for a team September 8, 2023 08:05
@vitorhugods
Copy link
Contributor

To make it possible to narrow the buttons, LocalMinimumInteractiveComponentEnforcement is disabled for WireButton (it makes the clickable elements to have minimal dimensions required by system)

Doesn't it cause an accessibility issue?

@saleniuk
Merge remote-tracking branch 'origin/release/candidate' into fix/conv…
2ea10f1 
…ersation_top_bar_spacing

# Conflicts:
#	app/src/main/kotlin/com/wire/android/ui/userprofile/common/UserProfileInfo.kt
@saleniuk
Copy link
Contributor Author

saleniuk commented Sep 8, 2023

To make it possible to narrow the buttons, LocalMinimumInteractiveComponentEnforcement is disabled for WireButton (it makes the clickable elements to have minimal dimensions required by system)

Doesn't it cause an accessibility issue?

I think it shouldn’t, as long as we don't set too small minClickableSize. Reducing it from 48.dp to 40.dp only in width should be still acceptable, but true - it may be a potential problem, but I believe that no one will accidentally create a button that is not clickable, by default they are set to have reasonable sizes, the same as required by the system.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 675 succeeded.

The build produced the following APK's:

@saleniuk saleniuk merged commit 45e8bf4 into release/candidate Sep 11, 2023
15 checks passed
@saleniuk saleniuk deleted the fix/conversation_top_bar_spacing branch September 11, 2023 07:56
@github-actions github-actions bot mentioned this pull request Sep 11, 2023
Merged
6 tasks
github-actions bot pushed a commit that referenced this pull request Sep 11, 2023
@saleniuk @github-actions
fix: conversation screen top bar spacing [WPB-971] (#2195)
4cc78d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandreferris alexandreferris alexandreferris approved these changes

@vitorhugods vitorhugods vitorhugods approved these changes

@typfel typfel Awaiting requested review from typfel typfel was automatically assigned from wireapp/android

@gongracr gongracr Awaiting requested review from gongracr gongracr was automatically assigned from wireapp/android

@borichellow borichellow Awaiting requested review from borichellow borichellow was automatically assigned from wireapp/android

@ohassine ohassine Awaiting requested review from ohassine ohassine was automatically assigned from wireapp/android

Assignees

@saleniuk saleniuk

Labels
size/XL
Projects
None yet
Milestone
No milestone
4 participants
@saleniuk @AndroidBob @vitorhugods @alexandreferris