fix: conversation screen top bar spacing [WPB-971] #2208
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
the
cherry-pick
|
Build 682 failed. |
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 684 succeeded. The build produced the following APK's: |
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 709 succeeded. The build produced the following APK's: |
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 723 succeeded. The build produced the following APK's: |
…op_bar_spacing-cherry-pick
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 730 succeeded. The build produced the following APK's: |
…op_bar_spacing-cherry-pick
Codecov Report
@@ Coverage Diff @@
## develop #2208 +/- ##
=============================================
- Coverage 40.89% 40.86% -0.03%
+ Complexity 997 996 -1
=============================================
Files 310 310
Lines 11430 11420 -10
Branches 1525 1524 -1
=============================================
- Hits 4674 4667 -7
+ Misses 6316 6313 -3
Partials 440 440
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 741 succeeded. The build produced the following APK's: |
Cherry pick from the original PR:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Current usage of space on the conversation screen top bar is not optimal and not much of the conversation title fits on the screen.
Solutions
Decrease spacing between top bar elements, reduce buttons widths, title font size and avatar size.
To make it possible to narrow the buttons,
LocalMinimumInteractiveComponentEnforcementis disabled forWireButton(it makes the clickable elements to have minimal dimensions required by system) and instead, new parameterminClickableSizeis provided to be able to apply custom values to that. Also,minWidthandminHeightare grouped intominSizeto keep consistency and all hardcoded button sizes are replaced with values defined inWireDimensions.Attachments (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.