fix: max accounts handling not respected (WPB-4818)

[yamilmedina]

---

PR Submission Checklist for internal contributors

• The PR Title

  • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
  • contains a reference JIRA issue number like SQPIT-764
  • answers the question: If merged, this PR will: ... ³

• The PR Description

  • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

---

What's new in this PR?

Issues

Some code were removed/adjusted and now we are not handling max account check on add "new account" self profile.

Causes (Optional)

We can add infinte? accounts.

Solutions

• Check for max accounts when trying to login, as a safety mechanism taking into consideration the Build flag.
• Create a proper state object for WelcomeScreen, so we handle them unified as in the rest of the project

Notes (Optional)

Moving forward and not for now, since this is critical for release.

• It was discovered https://wearezeta.atlassian.net/browse/WPB-1862
• Dead code, I left some marks to refactor/remove later.
• We can unify the Dialog used on deeplinks to the General Dialog approach used here, we can migrate later.

Testing

Test Coverage (Optional)

• I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Attachments (Optional)

Screen.Recording.2023-09-22.at.12.42.40.mov

---

PR Post Submission Checklist for internal contributors (Optional)

• Wire's Github Workflow has automatically linked the PR to a JIRA issue

---

PR Post Merge Checklist for internal contributors

• If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

---

References

1. https://sparkbox.com/foundry/semantic_commit_messages
2. https://github.com/wireapp/.github#usage
3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

[github-actions]

Test Results

587 tests   586 ✔️  7m 6s ⏱️
  84 suites      1 💤
  84 files        0 ❌

Results for commit 982920d.

[github-actions]

APKs built during tests are available here. Scroll down to Artifacts!

[alexandreferris]

Great catch!

I just have one comment that goes by more of a concern if it is possible to break it 🤔

[AndroidBob]

Build 903 succeeded.

The build produced the following APK's:

• com.wire.android-v4.4.0(7640911)(7640911)-staging-compat.apk

[gongracr]

Good catch 🔍 It would be also great to add some automated/integrated tests for this to make sure this doesn't slip away again. GJ 💪 🍓

[alexandreferris]

👌🏻

[github-actions]

APKs built during tests are available here. Scroll down to Artifacts!

[AndroidBob]

Build 905 succeeded.

The build produced the following APK's:

• com.wire.android-v4.4.0(7641240)(7641240)-staging-compat.apk