fix: max accounts handling not respected - dev (WPB-4818)

[github-actions]

WPB-4818 [Android] Max account limit not respected

Cherry pick from the original PR:

• fix: max accounts handling not respected (WPB-4818) #2257

---

⚠️ Conflicts during cherry-pick:

---

PR Submission Checklist for internal contributors

• The PR Title

  • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
  • contains a reference JIRA issue number like SQPIT-764
  • answers the question: If merged, this PR will: ... ³

• The PR Description

  • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

---

What's new in this PR?

Issues

Some code were removed/adjusted and now we are not handling max account check on add "new account" self profile.

Causes (Optional)

We can add infinte? accounts.

Solutions

• Check for max accounts when trying to login, as a safety mechanism taking into consideration the Build flag.
• Create a proper state object for WelcomeScreen, so we handle them unified as in the rest of the project

Notes (Optional)

Moving forward and not for now, since this is critical for release.

• It was discovered https://wearezeta.atlassian.net/browse/WPB-1862
• Dead code, I left some marks to refactor/remove later.
• We can unify the Dialog used on deeplinks to the General Dialog approach used here, we can migrate later.

Testing

Test Coverage (Optional)

• I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Attachments (Optional)

Screen.Recording.2023-09-22.at.12.42.40.mov

---

PR Post Submission Checklist for internal contributors (Optional)

• Wire's Github Workflow has automatically linked the PR to a JIRA issue

---

PR Post Merge Checklist for internal contributors

• If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

---

References

1. https://sparkbox.com/foundry/semantic_commit_messages
2. https://github.com/wireapp/.github#usage
3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

[codecov]

Codecov Report

Merging #2259 (d97b11c) into develop (4ce039e) will not change coverage.
Report is 2 commits behind head on develop.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             develop    #2259   +/-   ##
==========================================
  Coverage      40.37%   40.37%           
  Complexity      1007     1007           
==========================================
  Files            318      318           
  Lines          11619    11619           
  Branches        1539     1540    +1     
==========================================
  Hits            4691     4691           
  Misses          6489     6489           
  Partials         439      439           

Files Changed	Coverage Δ
...otlin/com/wire/android/ui/WireActivityViewModel.kt	70.37% <0.00%> (ø)
...roid/ui/authentication/welcome/WelcomeViewModel.kt	0.00% <0.00%> (ø)
...ndroid/ui/userprofile/self/SelfUserProfileState.kt	0.00% <0.00%> (ø)
...id/ui/userprofile/self/SelfUserProfileViewModel.kt	0.00% <ø> (ø)

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6dd35d...d97b11c. Read the comment docs.

[github-actions]

Test Results

611 tests   610 ✔️  6m 40s ⏱️
  88 suites      1 💤
  88 files        0 ❌

Results for commit d97b11c.

♻️ This comment has been updated with latest results.

[AndroidBob]

Build 912 succeeded.

The build produced the following APK's:

• com.wire.android-v4.5.0(7641603)(7641603)-staging-compat.apk

[github-actions]

APKs built during tests are available here. Scroll down to Artifacts!

[AndroidBob]

Build 917 succeeded.

The build produced the following APK's:

• com.wire.android-v4.5.0(7642248)(7642248)-staging-compat.apk