Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Adjust minimum characters to search to 1 (WPB-4915) #2420

Merged
merged 2 commits into from Nov 14, 2023
Merged

chore: Adjust minimum characters to search to 1 (WPB-4915) #2420

merged 2 commits into from Nov 14, 2023

Conversation

alexandreferris
Copy link
Contributor

@alexandreferris alexandreferris commented Nov 13, 2023 •
edited by github-actions bot

StoryWPB-4915 [Android] search for text inside the conversation

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

First ACs for search was that a minimum characters was set to 2. But after some internal discussions we decided on reducing it to 1 minimum character.

Solutions

Change minimum character to 1 instead of 2.

Testing

How to Test

  • Open App
  • Open Conversation
  • Open Conversation Details
  • Open Search Screen
  • Type 1 character and it should start loading results.

@alexandreferris alexandreferris changed the title chore: Adjust minimum characters to search to 1 chore: Adjust minimum characters to search to 1 (WPB-4915) Nov 13, 2023
@alexandreferris alexandreferris requested review from a team, typfel, gongracr, yamilmedina, MohamadJaara and ohassine and removed request for a team November 13, 2023 13:07
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 13, 2023 •
edited

Test Results

680 tests  ±0   680 ✔️ ±0   9m 20s ⏱️ +56s
  98 suites ±0       0 💤 ±0 
  98 files   ±0       0 ❌ ±0 

Results for commit fa0f75a. ± Comparison against base commit d0404eb.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1781 succeeded.

The build produced the following APK's:

@alexandreferris alexandreferris added this pull request to the merge queue Nov 14, 2023
Merged via the queue into develop with commit db858ea Nov 14, 2023
12 checks passed
@alexandreferris alexandreferris deleted the chore/adjust_search_message_min_character_to_1 branch November 14, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yamilmedina yamilmedina yamilmedina approved these changes

@Garzas Garzas Garzas approved these changes

@typfel typfel Awaiting requested review from typfel typfel was automatically assigned from wireapp/android

@gongracr gongracr Awaiting requested review from gongracr gongracr was automatically assigned from wireapp/android

@MohamadJaara MohamadJaara Awaiting requested review from MohamadJaara MohamadJaara was automatically assigned from wireapp/android

@ohassine ohassine Awaiting requested review from ohassine ohassine was automatically assigned from wireapp/android

Assignees

@alexandreferris alexandreferris

Labels
size/XS
Projects
None yet
Milestone
No milestone
4 participants
@alexandreferris @AndroidBob @yamilmedina @Garzas