Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Adjust minimum characters to search to 1 (WPB-4915) #2420

Merged
merged 2 commits into from
Nov 14, 2023
Merged

chore: Adjust minimum characters to search to 1 (WPB-4915) #2420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a12541
chore: adjust minimum characters to search to 1
alexandreferris Nov 13, 2023
fa0f75a
test: adjust tests
alexandreferris Nov 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...om/wire/android/ui/home/conversations/usecase/GetConversationMessagesFromSearchUseCase.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,6 @@ class GetConversationMessagesFromSearchUseCase @Inject constructor(
}

private companion object {
const val MINIMUM_CHARACTERS_TO_SEARCH = 2
const val MINIMUM_CHARACTERS_TO_SEARCH = 1
}
}
2 changes: 1 addition & 1 deletion ...ire/android/ui/home/conversations/usecase/GetConversationMessagesFromSearchUseCaseTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ class GetConversationMessagesFromSearchUseCaseTest {
.arrange()

// when
val result = useCase("a", arrangement.conversationId)
val result = useCase("", arrangement.conversationId)

// then
assert(result is Either.Right<List<UIMessage>>)
Expand Down