Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Display e2ei status of all devices #2584

Conversation

borichellow
Copy link
Contributor

@borichellow borichellow commented Jan 15, 2024

What's new in this PR?

Display E2EI statuses of each device in:

  • OtherUserProfile screen
  • MyDevices screen

Solutions

just do it

Attachments (Optional)

Screenshot 2024-01-16 at 14 19 51 Screenshot 2024-01-16 at 14 20 00

@borichellow borichellow self-assigned this Jan 15, 2024
Copy link
Contributor

github-actions bot commented Jan 15, 2024

Test Results

743 tests  ±0   743 ✅ ±0   10m 56s ⏱️ + 1m 20s
102 suites ±0     0 💤 ±0 
102 files   ±0     0 ❌ ±0 

Results for commit 100b544. ± Comparison against base commit 612465d.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 2558 failed.

@borichellow borichellow changed the base branch from develop to fix/verification_icons_dark_mode January 16, 2024 08:24
@pull-request-size pull-request-size bot added size/S and removed size/M labels Jan 16, 2024
@AndroidBob
Copy link
Collaborator

Build 2563 failed.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 2566 succeeded.

The build produced the following APK's:

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (612465d) 41.39% compared to head (100b544) 41.40%.

Additional details and impacted files
@@                          Coverage Diff                           @@
##             fix/verification_icons_dark_mode    #2584      +/-   ##
======================================================================
+ Coverage                               41.39%   41.40%   +0.01%     
  Complexity                               1129     1129              
======================================================================
  Files                                     361      361              
  Lines                                   13255    13259       +4     
  Branches                                 1742     1743       +1     
======================================================================
+ Hits                                     5487     5490       +3     
- Misses                                   7236     7237       +1     
  Partials                                  532      532              
Files Coverage Δ
.../android/ui/authentication/devices/model/Device.kt 95.00% <100.00%> (+0.55%) ⬆️
...ndroid/ui/settings/devices/SelfDevicesViewModel.kt 85.29% <60.00%> (-2.21%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 612465d...100b544. Read the comment docs.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 2577 succeeded.

The build produced the following APK's:

Copy link
Member

@mchenani mchenani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@mchenani mchenani merged commit 06876aa into fix/verification_icons_dark_mode Jan 16, 2024
17 checks passed
@mchenani mchenani deleted the feat/display_e2ei_status_of_all_devices branch January 16, 2024 14:50
@mchenani mchenani restored the feat/display_e2ei_status_of_all_devices branch January 16, 2024 14:50
@mchenani mchenani deleted the feat/display_e2ei_status_of_all_devices branch January 16, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants