Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: download asset dialog button order (WPB-5378) #2595

Merged
merged 2 commits into from Jan 18, 2024

Conversation

alexandreferris
Copy link
Contributor

@alexandreferris alexandreferris commented Jan 18, 2024

TaskWPB-5378 Files tab in media gallery


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

When checking upon QA on Media Gallery, download assets dialog were showing the buttons SAVE and OPEN in incorrect order, and the label was missing a comma from the string.

Solutions

  • Invert the buttons
  • add missing comma to string label

How to Test

Either from Media Gallery or normal conversation screen, click to download an asset.

Attachments (Optional)

Before After
after after

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@alexandreferris alexandreferris changed the title fix: download asset dialog button order fix: download asset dialog button order (WPB-5378) Jan 18, 2024
@alexandreferris alexandreferris requested review from a team, typfel, borichellow, Garzas, ohassine and saleniuk and removed request for a team January 18, 2024 13:35
Copy link
Contributor

Test Results

744 tests  ±0   744 ✅ ±0   7m 43s ⏱️ - 2m 31s
102 suites ±0     0 💤 ±0 
102 files   ±0     0 ❌ ±0 

Results for commit 1793876. ± Comparison against base commit 3c0301a.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 2641 succeeded.

The build produced the following APK's:

@MohamadJaara MohamadJaara added this pull request to the merge queue Jan 18, 2024
Merged via the queue into develop with commit 4f388a6 Jan 18, 2024
17 checks passed
@MohamadJaara MohamadJaara deleted the fix/download_asset_dialog_button_order branch January 18, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants