Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve enrollment dialog (WPB-4372) #2610

Merged
merged 14 commits into from Jan 23, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Jan 23, 2024

TaskWPB-4372 [Android] Misleading Backend Enrollment Dialogue


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

We need to provide in the deeplink enrollment dialog to a custom backend more information about the links

Causes (Optional)

Security requirement.

Solutions

  • Refactor the dialog component, to make scrollable the dynamic content.
  • Pass the new deeplink data to display in the dialog.

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Manually tested, open a deeplink, you should see more information.

Attachments (Optional)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina requested a review from a team January 23, 2024 15:22
@yamilmedina yamilmedina self-assigned this Jan 23, 2024
@yamilmedina yamilmedina requested review from typfel, borichellow, Garzas, ohassine and saleniuk and removed request for a team January 23, 2024 15:22
@yamilmedina yamilmedina requested review from alexandreferris and MohamadJaara and removed request for typfel January 23, 2024 15:22
Copy link
Contributor

Test Results

750 tests   750 ✅  7m 31s ⏱️
105 suites    0 💤
105 files      0 ❌

Results for commit 4296840.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@yamilmedina yamilmedina enabled auto-merge (squash) January 23, 2024 16:08
@AndroidBob
Copy link
Collaborator

Build 2693 succeeded.

The build produced the following APK's:

@yamilmedina yamilmedina merged commit 97eacae into release/candidate Jan 23, 2024
10 of 11 checks passed
@yamilmedina yamilmedina deleted the feat/improve-enrollment-dialog branch January 23, 2024 17:13
@yamilmedina yamilmedina restored the feat/improve-enrollment-dialog branch January 23, 2024 17:18
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants